Add support for using auth informations from URL #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This functionality existed before c2d6d1a |
Member
|
Hey thank you for spotting this and making a PR, I'm going to review and test it and get back to you 👍 |
Member
|
Changes LGTM 👍 Though we should probably (somehow) indicate that we're talking about Basic access authentication here. |
WyriHaximus
added a commit
that referenced
this pull request
Jun 15, 2015
Add support for using auth informations from URL
Member
|
Once again thank you for the PR, I'll tag is shortly 👍 |
Member
|
@clue Yeah we should, my goal is to support all HTTP RFC's in the future anyway so this is a nice start :). |
Contributor
Author
|
Thanks @WyriHaximus @clue :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes RequestData such that if the provided URL contains a user and optionally a password, they will be used for generating an
Authorization: Basic ...header.