cleanup

Author: mjcuva

commands/deploy.js

@@ -16,6 +16,7 @@ const path = require('path');
 const createEnquirer = require('../lib/enquirer');
 const ProgressBar = require('progress');
 const utils = require('../utils/utils');
+const exit = require('../utils/exit');
 
 const readmePath = path.join(process.cwd(), 'readme.md');
 const zipDir = path.join(utils.cacheDir(), 'output.zip');
@@ -117,7 +118,7 @@ module.exports.deploy = (packageJson, defaultTeam, answers) => {
       docs = buildDocs.parseDirectory(path.join(process.cwd(), 'endpoints'));
     } catch (e) {
       console.error(`\nError generating documentation: ${e.message.red}\n`);
-      process.exit(1);
+      exit(1);
     }
 
     // Check if user edited the documentation
@@ -129,7 +130,7 @@ module.exports.deploy = (packageJson, defaultTeam, answers) => {
       for (const doc of unchangedDocs) {
         console.error(`endpoints/${doc}.js\n`.green);
       }
-      process.exit(1);
+      exit(1);
     }
 
     form.append('version', packageJson.get('version'));

test/utils/utils.test.js

@@ -7,7 +7,7 @@ describe('utils', () => {
     it('Return with an empty array if docs changed', () => {
       const docs = [{ name: 'helloWorld' }];
       const unchanged = utils.getUnchangedDocs(docs);
-      assert(unchanged, []);
+      assert.deepEqual(unchanged, []);
     });
 
     it('Should return with action name if unchanged', () => {
@@ -18,7 +18,7 @@ describe('utils', () => {
         returns: { description: 'A very friendly greeting', type: 'string' },
       }];
       const unchanged = utils.getUnchangedDocs(defaultDocs);
-      assert(unchanged, ['helloWorld']);
+      assert.deepEqual(unchanged, ['helloWorld']);
     });
   });
 });

utils/utils.js

@@ -152,11 +152,6 @@ exports.buildErrors = (baseDir = process.cwd()) => {
 
 // Get names of files still containing stub documentation
 exports.getUnchangedDocs = (docs) => {
-  const unchanged = [];
-  for (const doc of docs) {
-    if (doc.fullDescription && doc.fullDescription.indexOf('https://docs.readme.build/docs/writing-documentation') >= 0) {
-      unchanged.push(doc.name);
-    }
-  }
-  return unchanged;
+  return docs.filter(doc => doc.fullDescription && doc.fullDescription.indexOf('https://docs.readme.build/docs/writing-documentation') >= 0)
+  .map(doc => doc.name);
 };