Skip to content

Conversation

erunion
Copy link
Member

@erunion erunion commented Jul 13, 2020

🧰 What's being changed?

Sets a custom user agent for all requests that the SDK makes.

Resolves #104

@erunion erunion added enhancement New feature or request area:core Issues related to `core`, which is the package that powers the SDKs at runtime labels Jul 13, 2020
@gkoberger
Copy link
Contributor

Yesss! I'm excited to surface a cute little icon on the API Logs :)

Copy link
Member

@kanadgupta kanadgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only thing is that api/2.x.x seems a bit generic, but not sure of any better ideas

@erunion
Copy link
Member Author

erunion commented Jul 13, 2020

@kanadgupta What about api (node)/2.x.x?

@kanadgupta
Copy link
Member

What about api (node)/2.x.x?

@erunion I'm good with that! I'd love to hear @domharrington's opinions on this too

@erunion erunion merged commit 25cefef into master Jul 13, 2020
@erunion erunion deleted the feat/set-user-agent branch July 13, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core Issues related to `core`, which is the package that powers the SDKs at runtime enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SDK should be setting a user agent for itself

4 participants