fix: if no cache dir is determined, fallback to the os temp dir #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
commented
Sep 8, 2020
| "form-data": "^3.0.0", | ||
| "get-stream": "^6.0.0", | ||
| "js-yaml": "^3.14.0", | ||
| "make-dir": "^3.1.0", |
There was a problem hiding this comment.
This module is already coming in via find-cache-dir, so I'm using that instead of loading in something else like mktemp.
erunion
added
area:core
domharrington
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
This resolves #107 and edge case with the find-cache-dir module where if it can't determine a cache directory, it'll return
undefined. When this could crop up is if a user runsnpm install apiin a fresh directory without apackage.jsonfile. Sincefind-cache-dirlooks for the root-most directory with apackage.jsonfile to determine where to put its.cache/directory intonode_modules/, it can't.So to account for this edge case, if we end up with an undefined cache directory from the module we'll instead fallback to creating a temp directory at the OS level.