fix: quirks in oas-to-har where query params are not being URI encoded #331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
This upgrades
@readme/oas-to-har
to fix a quirk with query parameter handling where data is not being URL encoded before it's sent off tofetch-har
to making a request.See readmeio/oas-to-har#16 for more details on the fix.
🧬 Testing
You can see this quirk in action right now against
main
by running the following snippet:Whereas if you run those parameters through
encodeURIComponent()
, or with thisoas-to-har
update, the resulting payload from https://httpbin.org looks right: