Skip to content

fix: crash where multipart/form-data requests dont have params #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2021
Merged

fix: crash where multipart/form-data requests dont have params #360

merged 1 commit into from
Dec 10, 2021

Conversation

erunion
Copy link
Member

@erunion erunion commented Dec 10, 2021

🧰 What's being changed?

Much like readmeio/httpsnippet#65 this also fixes this case where a multipart/form-data HAR might not have postData.params present.

@erunion erunion added bug Something isn't working area:snippets Issues related to code snippets labels Dec 10, 2021
@erunion erunion merged commit 5762c22 into main Dec 10, 2021
@erunion erunion deleted the fix/multipart-no-params branch December 10, 2021 22:13
@erunion erunion mentioned this pull request Dec 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gratcliff gratcliff gratcliff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:snippets Issues related to code snippets bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erunion @gratcliff