feat: HTTP Snippet client for Node samples #52
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
This creates a new package,
httpsnippet-client-api
, that allows for the creation of Node code samples, via httpsnippet, for theapi
module.Using the new plugin architecture I've PR'd to HTTP Snippet, we can load in this new client with the following lines:
And once it's loaded, you can use HTTP Snippet as you would any other target+client combination:
🧪 Testing
Since the unit tests for
httpsnippet
are pretty ingrained into that repository, I've extracted the target-related tests and all their fixtures to facilitate testing this module. As such since we're pulling in code I didn't write, I am also pulling in their license.Ideally this code/plugin infrastructure would be available in a generator package like generator-eslint, but that is way out of scope for this right now. Maybe once the plugin PR is accepted into httpsnippet, and we start building additional
api
clients for different languages, we can work on something there. Until then, yolo.🗳 Checklist