fix: moving off fs/promises to fs in client-side code
#605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
added
bug
erunion
requested review from
a team,
Dashron,
domharrington and
kanadgupta
and removed request for
a team
domharrington
approved these changes
Jan 17, 2023
kanadgupta
reviewed
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Some client frameworks seem to not polyfill
fs/promiseswhich we're using in our parameter preparation tooling for handling files being supplied to SDKs. As they do polyfillfs, I'm switching the bit where we usefs/promisesto that and then writing an ESLint rule to prevent us from introducing a regression.