Fixed #16 - Incorrect test duration with freezegun #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petedmarsh
force-pushed
the
master
branch
2 times, most recently
from
f7db4b8 to
36f041b
Compare
freezegun is a Python library used to set the date/time returned by the Python date/time functions to make testing time-sensitive code easier. time.time() is used here to measure the duration of test cases, if freezegun was in use then the time returned by this could be the time the test had set up, rather than the actual time. This lead to test durations being reported as negative (if frozen time is in the past), or much longer than expected (if fronzen time is in the future). freezegun exposes the unmodified time.time() via an alias. This changes TimingSuite so that it uses this alias if freezegun is installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
freezegun is a Python library used to set the date/time returned by
the Python date/time functions to make testing time-sensitive code
easier.
time.time() is used here to measure the duration of test cases, if
freezegun was in use then the time returned by this could be the
time the test had set up, rather than the actual time. This lead to
test durations being reported as negative (if frozen time is in the
past), or much longer than expected (if fronzen time is in the
future).
freezegun exposes the unmodified time.time() via an alias. This
changes TimingSuite so that it uses this alias if freezegun is
installed.