Update cheatsheet with map/forEach examples #431
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @rickyvetter, what do you think of this PR? :) |
yawaramin
reviewed
Jun 3, 2019
Contributor
yawaramin
left a comment
yawaramin
left a comment
There was a problem hiding this comment.
I recommend moving the examples inside the existing 'Array' table ( https://reasonml.github.io/docs/en/syntax-cheatsheet#array ) instead of creating a new table.
|
|
||
| | JavaScript | Reason | | ||
| |------------------------------------------|-------------------------------------------| | ||
| |`[1,2,3].forEach(i => { console.log(i) })`|`Array.iter(i => { Js.log(i) }, [|1,2,3|])`| |
Contributor
There was a problem hiding this comment.
Reason version can be Array.iter(Js.log, [|1, 2, 3|])
| | JavaScript | Reason | | ||
| |------------------------------------------|-------------------------------------------| | ||
| |`[1,2,3].forEach(i => { console.log(i) })`|`Array.iter(i => { Js.log(i) }, [|1,2,3|])`| | ||
| |`[1,2,3].map(i => { return i + 1 })` |`Array.map(i => i + 1, [|1,2,3|])` | |
Contributor
There was a problem hiding this comment.
Reason version can be Array.map(succ, [|1, 2, 3|]). Admittedly i => i + 1 is just as valid but if we want to show the idiomatic way of doing things in OCaml/Reason we might as well teach the built-in functions...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is good for a beginner to see how ReasonML is handling looping over an array.
How the array is giving as a argument.