-
Notifications
You must be signed in to change notification settings - Fork 132
[FIX]: #1017 Hamburger Menu Appears but Doesn't Display Content Between 1300px and 996px Screen Width #1060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@kanishka-commits is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
|
✅ Synchronized metadata from Issue #1017:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start though I don’t think this fully solves the problem as intended. It might be worth checking section 10. Try to find a sweet spot for both of them. I would suggest look a bit more into media query and how it should handle breakpoints in mobile and tablet as well as desktop
|
@kanishka-commits this is what i see i can see the github icon on medium screen |
|
✅ Synchronized metadata from Issue #1017:
|
|
✅ Synchronized metadata from Issue #1017:
|
|
✅ Synchronized metadata from Issue #1017:
|
|
✅ Synchronized metadata from Issue #1017:
|
|
@sheikhlimon About the GitHub, I've made the necessary changes:
Kindly review the commits and let me know. Changes made 505621649-cdc4beb7-5fbf-4e89-a296-59482dfb11a3.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@sheikhlimon |
Edit: I was able to achieve this when i tried to fix it but couldn't fix it after this point |
|
@sheikhlimon Regarding the “Sign in” text, the changes have already been implemented in the latest commit, please take a look to see the updated version. |
i can see the Sign in on medium screen that part is done.. im talking about normal screen the more and sign in is overlapping each other |
@kanishka-commits I have attached the resolution here i see this on.. so check it out if you see the same |
|
@sheikhlimon As I can see, on both my local as well as deployed web-app, the gap between the left (docs->more) and right nav-items(github->toggle) are significant but on your local device, it looks as if it's not present there, May I know why is this the case? |
check on 1268.. 1338 is good |
@sheikhlimon |
@kanishka-commits I just checked on multiple browsers, and the behavior is different on every single one of them... playing with media query in docusaurus is like fighting with it...lol.. the default docusaurus makes it look snappier i guess everything looks fine.. with your changes.. this seems like an ok fix... but not satisfactory to me.. But nonetheless, I really appreciate the work you put in.. Thank you.. |
|
@sheikhlimon |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|












Description
Fixes #1017
Problem Summary
The issue was caused by a breakpoint mismatch between the custom CSS and Docusaurus’s default responsive behavior.
As a result, the hamburger menu appeared but did not function between screen widths of 1300px and 996px.
Why This Happened
Section 11), a media query@media (max-width: 1299px)was used to hide navbar items and show the hamburger icon.@media (max-width: 996px).Solution Summary
The PR introduces a 3-step fix that completely resolves the dead zone and improves the overall responsiveness of the navbar.
1. Aligned Breakpoint (Core Fix)
Earlier
Screen.Recording.2025-10-25.at.12.11.53.AM.mov
custom.css(Section 11) frommax-width: 1299px→max-width: 996px.2. Responsive UI Update
@media (max-width: 1110px)) to hide the “Sign in with GitHub” text, keeping only the icon visible.3. Button Consistency (UX Improvement)
Earlier

Type of Change
Changes Made
Screen.Recording.2025-10-25.at.12.10.06.AM.mov
996px)Dependencies
Checklist
npm run buildsuccessfully and verified responsive behavior