Skip to content

Conversation

@kanishka-commits
Copy link
Contributor

Description

This PR fixes a UI bug where the active navigation/scroll indicator dot was not clearly visible in light mode. The dot's color blended in with the background, making it difficult for users to see which section was currently active.

This change updates the background color of the active dot to provide sufficient contrast, resolving the visibility issue and improving the user experience.

Fixes #975

Type of Change

  • New feature (e.g., new page, component, or functionality)
  • Bug fix (non-breaking change that fixes an issue)
  • UI/UX improvement (design, layout, or styling updates)
  • Performance optimization (e.g., code splitting, caching)
  • Documentation update (README, contribution guidelines, etc.)
  • Other (please specify):

Changes Made

  • Initially attempted to use simple responsive colors (bg-black and dark:bg-white). However, the dark:bg-white style was not being applied correctly in dark mode, likely due to a CSS specificity conflict with the base theme.
  • To resolve this and ensure visibility, the buttonVariants cva definition (in the Button component file) was modified.
  • The default variant's light-mode background color was updated to bg-[#5FBFA2] (rgb 95, 191, 162) to ensure it is clearly visible.
  • The high-contrast dark mode style (dark:bg-white) used by other variants was confirmed to be working as expected.
Screen.Recording.2025-10-25.at.11.40.47.PM.mov

Dependencies

  • None.

Checklist

  • My code follows the style guidelines of this project.
  • I have tested my changes across major browsers and devices
  • My changes do not generate new console warnings or errors .
  • I ran npm run build and attached screenshot(s) in this PR.
  • This is already assigned Issue to me, not an unassigned issue.

@vercel
Copy link
Contributor

vercel bot commented Oct 25, 2025

@kanishka-commits is attempting to deploy a commit to the recode Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs.

In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊

Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv.

We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰

🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨

📚Your perks for contribution to this community 👇🏻

  1. Get free Consultation use code recode50 to get free: Mentorship for free.

  2. Get the Ebook for free use code recode at checkout: Data Science cheatsheet for Beginners.

  3. Check out this weekly Newsletter: Sanjay's Newsletter.

If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@github-actions github-actions bot added hacktoberfest-accepted recode this is label for leaderboard level 1 10 points labels Oct 25, 2025
@github-actions github-actions bot added this to the recode:launch 3.0 milestone Oct 25, 2025
@github-actions
Copy link

✅ Synchronized metadata from Issue #975:

  • Labels: level 1, recode, hacktoberfest-accepted
  • Milestone: recode:launch 3.0

@github-actions
Copy link

✅ Synchronized metadata from Issue #5:

  • Labels: None
  • Milestone: None

Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
@github-actions
Copy link

✅ Synchronized metadata from Issue #975:

  • Labels: level 1, recode, hacktoberfest-accepted
  • Milestone: recode:launch 3.0

@github-actions
Copy link

✅ Synchronized metadata from Issue #5:

  • Labels: None
  • Milestone: None

@vercel
Copy link
Contributor

vercel bot commented Oct 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
recode-website Ready Ready Preview Comment Oct 26, 2025 9:14am

@sanjay-kv sanjay-kv merged commit c07ad7c into recodehive:main Oct 26, 2025
6 checks passed
@sanjay-kv
Copy link
Member

Thats a good find @kanishka-commits . the changes you made was highly valued. please enable github sponsorship.

or if you up for recieveing free mentorship i can give you the coupon codes.

@kanishka-commits
Copy link
Contributor Author

Thanks a lot, @sanjay-kv!
I’ve enabled GitHub sponsorship as suggested earlier.
The mentorship sounds amazing! I’d love to gain more hands-on experience and explore ways to contribute to your projects, and I’m open to taking on meaningful roles along the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted level 1 10 points recode this is label for leaderboard

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Navigation Dots Not Visible When Active

2 participants