Skip to content

Conversation

iitzIrFan
Copy link
Member

Description

Fixed the navbar issue. Whenever we visit giveaway page, the navbar us different as compared to other pages. Fixed that, behaviour between switch other tabs on the leaderboard section.
Solves: #529

Type of Change

  • New feature (e.g., new page, component, or functionality)
  • Bug fix (non-breaking change that fixes an issue)
  • UI/UX improvement (design, layout, or styling updates)
  • Performance optimization (e.g., code splitting, caching)
  • Documentation update (README, contribution guidelines, etc.)
  • Other (please specify):

Changes Made

First giveaway page had some different navbar so, made it similar to other sections.

Checklist

  • My code follows the style guidelines of this project.
  • I have tested my changes across major browsers and devices
  • My changes do not generate new console warnings or errors .
  • I ran npm run build and attached screenshot(s) in this PR.
  • This is already assigned Issue to me, not an unassigned issue.

@iitzIrFan iitzIrFan requested a review from sanjay-kv September 20, 2025 13:49
@iitzIrFan iitzIrFan self-assigned this Sep 20, 2025
@iitzIrFan iitzIrFan added kind:bug This is a clearly a bug priority:critical Showstopper bug that should be patched immediately priority:high High priority bug that should be patched quickly but does not require immediate new release labels Sep 20, 2025
Copy link

vercel bot commented Sep 20, 2025

Someone is attempting to deploy a commit to the recode Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs.

In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊

Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv.

We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰

🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨

📚Your perks for contribution to this community 👇🏻

  1. Get free Consultation use code recode50 to get free: Mentorship for free.

  2. Get the Ebook for free use code recode at checkout: Data Science cheatsheet for Beginners.

  3. Check out this weekly Newsletter: Sanjay's Newsletter.

If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@iitzIrFan iitzIrFan moved this to In Progress in @recode-web Sep 20, 2025
@Adez017
Copy link
Member

Adez017 commented Sep 20, 2025

This is indeed needed @iitzIrFan , great to see :)

@iitzIrFan iitzIrFan linked an issue Sep 20, 2025 that may be closed by this pull request
4 tasks
Copy link

vercel bot commented Sep 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
recode-website Ready Ready Preview Comment Sep 20, 2025 3:42pm

@Adez017
Copy link
Member

Adez017 commented Sep 20, 2025

Hi @iitzIrFan, I think there is an issue with the links. Also, the link for the leaderboard still references 'contributors'; could you fix that as well?
image

@iitzIrFan
Copy link
Member Author

@Adez017 Thanks for pointing it out, yeah there was an issue with the route naming convention. Will update in this PR.

@sanjay-kv

@iitzIrFan
Copy link
Member Author

@Adez017 Done :)
@sanjay-kv Ready for merge.

@sanjay-kv sanjay-kv merged commit a65f434 into recodehive:main Sep 21, 2025
1 of 2 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in @recode-web Sep 21, 2025
@sanjay-kv sanjay-kv added level 1 10 points recode this is label for leaderboard labels Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:bug This is a clearly a bug level 1 10 points priority:critical Showstopper bug that should be patched immediately priority:high High priority bug that should be patched quickly but does not require immediate new release recode this is label for leaderboard

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Layout issue on giveaway

3 participants