fixed the filters PR Modal #605

Adez017 · 2025-09-26T05:34:30Z

Description

Fixes #601

Type of Change

New feature (e.g., new page, component, or functionality)
Bug fix (non-breaking change that fixes an issue)
UI/UX improvement (design, layout, or styling updates)
Performance optimization (e.g., code splitting, caching)
Documentation update (README, contribution guidelines, etc.)
Other (please specify):

Changes Made

Dependencies

List any new dependencies or tools required for this change.
Mention any version updates or configurations that need to be considered.

Checklist

My code follows the style guidelines of this project.
I have tested my changes across major browsers and devices
My changes do not generate new console warnings or errors .
I ran npm run build and attached screenshot(s) in this PR.
This is already assigned Issue to me, not an unassigned issue.

Screen.Recording.2025-09-26.110034.mp4

vercel · 2025-09-26T05:34:34Z

@Adez017 is attempting to deploy a commit to the recode Team on Vercel.

A member of the Team first needs to authorize it.

github-actions · 2025-09-26T05:34:38Z

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs.

In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊

Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv.

We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰

🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨

📚Your perks for contribution to this community 👇🏻

Get free Consultation use code recode50 to get free: Mentorship for free.
Get the Ebook for free use code recode at checkout: Data Science cheatsheet for Beginners.
Check out this weekly Newsletter: Sanjay's Newsletter.

If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Adez017 · 2025-09-26T05:34:51Z

Check it out @sanjay-kv @iitzIrFan

Copilot

Pull Request Overview

This PR fixes a filtering issue in the PR Modal by implementing proper time-based filtering for pull requests. The change refactors the stats provider to store all PR data and compute filtered results based on the selected time period, ensuring the modal displays the correct PRs for the chosen filter.

Enhanced the stats provider to store full PR history and compute filtered results dynamically
Updated the leaderboard to use context-based time filtering instead of simulated filtering
Modified the PR modal to display filtered PRs based on the current time selection

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
src/lib/statsProvider.tsx	Added time filtering logic, enhanced data storage to keep full PR history, and exposed filtering functions
src/components/dashboard/LeaderBoard/leaderboard.tsx	Removed local time filtering simulation and integrated with context-based filtering
src/components/dashboard/LeaderBoard/PRListModal.tsx	Updated to use filtered PRs from context instead of static contributor data

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-26T05:36:03Z

src/lib/statsProvider.tsx

+// Time filter utility functions
+const getTimeFilterDate = (filter: TimeFilter): Date | null => {
+  const now = new Date();
+  switch (filter) {
+    case 'week':
+      return new Date(now.getTime() - 7 * 24 * 60 * 60 * 1000);
+    case 'month':
+      return new Date(now.getTime() - 30 * 24 * 60 * 60 * 1000);
+    case 'year':
+      return new Date(now.getTime() - 365 * 24 * 60 * 60 * 1000);


The time calculation uses magic numbers for milliseconds. Consider extracting these into named constants for better maintainability.

Suggested change

// Time filter utility functions

const getTimeFilterDate = (filter: TimeFilter): Date | null => {

const now = new Date();

switch (filter) {

case 'week':

return new Date(now.getTime() - 7 * 24 * 60 * 60 * 1000);

case 'month':

return new Date(now.getTime() - 30 * 24 * 60 * 60 * 1000);

case 'year':

return new Date(now.getTime() - 365 * 24 * 60 * 60 * 1000);

// Time-related constants for better maintainability

const MILLISECONDS_PER_SECOND = 1000;

const SECONDS_PER_MINUTE = 60;

const MINUTES_PER_HOUR = 60;

const HOURS_PER_DAY = 24;

const DAYS_PER_WEEK = 7;

const DAYS_PER_MONTH = 30; // Approximate

const DAYS_PER_YEAR = 365; // Non-leap year

const MILLISECONDS_PER_DAY = HOURS_PER_DAY * MINUTES_PER_HOUR * SECONDS_PER_MINUTE * MILLISECONDS_PER_SECOND;

const MILLISECONDS_PER_WEEK = DAYS_PER_WEEK * MILLISECONDS_PER_DAY;

const MILLISECONDS_PER_MONTH = DAYS_PER_MONTH * MILLISECONDS_PER_DAY;

const MILLISECONDS_PER_YEAR = DAYS_PER_YEAR * MILLISECONDS_PER_DAY;

// Time filter utility functions

const getTimeFilterDate = (filter: TimeFilter): Date | null => {

const now = new Date();

switch (filter) {

case 'week':

return new Date(now.getTime() - MILLISECONDS_PER_WEEK);

case 'month':

return new Date(now.getTime() - MILLISECONDS_PER_MONTH);

case 'year':

return new Date(now.getTime() - MILLISECONDS_PER_YEAR);

src/lib/statsProvider.tsx

Copilot · 2025-09-26T05:36:04Z

src/components/dashboard/LeaderBoard/PRListModal.tsx

                  <p className={`pr-modal-subtitle ${isDark ? "dark" : "light"}`}>
-                    {contributor.prs} merged PR{contributor.prs !== 1 ? 's' : ''} • {contributor.points} points
+                    {/*Show filtered count and add filter info */}
+                    {filteredPRs.length} merged PR{filteredPRs.length !== 1 ? 's' : ''} • {filteredPRs.length * 10} points


The points calculation uses a magic number (10). Consider importing POINTS_PER_PR constant from statsProvider or defining it as a shared constant to maintain consistency.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-26T07:32:51Z

src/components/dashboard/LeaderBoard/leaderboard.tsx

                  onChange={(e) => {
-                    setTimePeriod(e.target.value as TimePeriod);
+                    // Use setTimeFilter from context
+                    setTimeFilter(e.target.value as any);


Using as any bypasses TypeScript's type safety. Since TimeFilter is already defined, cast to the specific type: setTimeFilter(e.target.value as TimeFilter) to maintain type safety.

Suggested change

setTimeFilter(e.target.value as any);

setTimeFilter(e.target.value as TimeFilter);

vercel · 2025-09-27T02:01:05Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
recode-website	Ready	Preview	Comment	Sep 27, 2025 2:01am

fixed the filters

b73da1d

Copilot AI review requested due to automatic review settings September 26, 2025 05:34

Adez017 requested review from iitzIrFan and sanjay-kv September 26, 2025 05:35

Copilot AI reviewed Sep 26, 2025

View reviewed changes

Update src/lib/statsProvider.tsx

950b8ee

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings September 26, 2025 07:30

Copilot AI reviewed Sep 26, 2025

View reviewed changes

sanjay-kv approved these changes Sep 27, 2025

View reviewed changes

sanjay-kv assigned Adez017 Sep 27, 2025

sanjay-kv added gssoc25 level 2 30 points labels Sep 27, 2025

vercel bot deployed to Preview September 27, 2025 02:01 View deployment

sanjay-kv added this to @recode-web Sep 27, 2025

sanjay-kv moved this to In Progress in @recode-web Sep 27, 2025

sanjay-kv added this to the recode:launch 3.0 milestone Sep 27, 2025

sanjay-kv merged commit cfb379c into recodehive:main Sep 27, 2025
3 checks passed

github-project-automation bot moved this from In Progress to Done in @recode-web Sep 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fixed the filters PR Modal #605

fixed the filters PR Modal #605

Uh oh!

Adez017 commented Sep 26, 2025

Uh oh!

vercel bot commented Sep 26, 2025

Uh oh!

github-actions bot commented Sep 26, 2025

Uh oh!

Adez017 commented Sep 26, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 26, 2025

Uh oh!

Uh oh!

Copilot AI Sep 26, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 26, 2025

Uh oh!

vercel bot commented Sep 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	setTimeFilter(e.target.value as any);
	setTimeFilter(e.target.value as TimeFilter);

fixed the filters PR Modal #605

fixed the filters PR Modal #605

Uh oh!

Conversation

Adez017 commented Sep 26, 2025

Description

Type of Change

Changes Made

Dependencies

Checklist

Uh oh!

vercel bot commented Sep 26, 2025

Uh oh!

github-actions bot commented Sep 26, 2025

Uh oh!

Adez017 commented Sep 26, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

vercel bot commented Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Sep 27, 2025 •

edited

Loading