Skip to content

Conversation

@SnehaTingare
Copy link
Contributor

@SnehaTingare SnehaTingare commented Oct 20, 2025

Added a search icon (🔍) inside the Ebook Page search bar and updated the CSS to make the icon visible and properly aligned. This improves the UI/UX of the search functionality.
Fixes #930

Type of Change

  • New feature (e.g., new page, component, or functionality)
  • Bug fix (non-breaking change that fixes an issue)
  • UI/UX improvement (design, layout, or styling updates)
  • Performance optimization (e.g., code splitting, caching)
  • Documentation update (README, contribution guidelines, etc.)
  • Other (please specify):

Changes Made

Wrapped the search input in a div with class ebook-search-wrapper.

Added a span with class search-icon containing the magnifying glass emoji.

Updated index.css for .ebook-search-wrapper and .search-icon for proper positioning.

Adjusted padding of search input to accommodate the icon.

Dependencies

No new dependencies added.

Screenshot 2025-10-20 161314

Checklist

  • My code follows the style guidelines of this project.
  • I have tested my changes across major browsers and devices
  • My changes do not generate new console warnings or errors .
  • I ran npm run build and attached screenshot(s) in this PR.
  • This is already assigned Issue to me, not an unassigned issue.

@vercel
Copy link
Contributor

vercel bot commented Oct 20, 2025

@SnehaTingare is attempting to deploy a commit to the recode Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs.

In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊

Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv.

We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰

🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨

📚Your perks for contribution to this community 👇🏻

  1. Get free Consultation use code recode50 to get free: Mentorship for free.

  2. Get the Ebook for free use code recode at checkout: Data Science cheatsheet for Beginners.

  3. Check out this weekly Newsletter: Sanjay's Newsletter.

If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@github-actions github-actions bot added hacktoberfest-accepted recode this is label for leaderboard labels Oct 20, 2025
@github-actions
Copy link

Synced data from Linked Issues

Labels:

  • level 1
  • recode
  • hacktoberfest-accepted

Assignees:

  • SnehaTingare

Milestones:

  • recode:launch 3.0

@SnehaTingare
Copy link
Contributor Author

I am writing to confirm that the referenced issue has been fully addressed and the implementation is complete. All changes have been tested, and there are no merge conflicts with the current main branch.

Kindly proceed to review and merge the changes at your earliest convenience.

@iitzIrFan iitzIrFan self-requested a review October 20, 2025 17:36
@iitzIrFan iitzIrFan added the under review Review under the maintainers or the admins label Oct 20, 2025
@iitzIrFan iitzIrFan moved this to In Progress in @recode-web Oct 20, 2025
Copy link
Member

@iitzIrFan iitzIrFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @SnehaTingare
@sanjay-kv Ready for merge.

@iitzIrFan iitzIrFan added the Ready for Merge PR has passed reviews and checks, and is ready to be merged into the main branch. label Oct 20, 2025
@sanjay-kv sanjay-kv added the level 3 50 points label Oct 21, 2025
@vercel
Copy link
Contributor

vercel bot commented Oct 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
recode-website Ready Ready Preview Comment Oct 21, 2025 2:56pm

@iitzIrFan iitzIrFan removed the under review Review under the maintainers or the admins label Oct 21, 2025
@sanjay-kv sanjay-kv merged commit d7ac4a7 into recodehive:main Oct 21, 2025
13 of 20 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in @recode-web Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted level 3 50 points Ready for Merge PR has passed reviews and checks, and is ready to be merged into the main branch. recode this is label for leaderboard

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Add a search icon in the "Search ebooks" search bar for better UI consistency

3 participants