Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#831): Remove sort field when only one is applied #1116

Merged
merged 3 commits into from Feb 9, 2022

Conversation

leiyre
Copy link
Member

@leiyre leiyre commented Feb 9, 2022

This PR allows to remove sort field from cross button when only one is applied

Closes #831

fix #831
This PR allows to remove sort field from cross button when only one is applied
Copy link
Member

@frascuchon frascuchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For small PRs like this, you should include basic test specs. Please include a basic test using snapshots.

@frascuchon frascuchon merged commit f446974 into master Feb 9, 2022
@frascuchon frascuchon deleted the fix/remove_single_sort_field branch February 9, 2022 15:47
frascuchon pushed a commit that referenced this pull request Feb 10, 2022
This PR allows to remove sort field from cross button when only one is applied

Closes #831

* SortList test

* SorlList snap

(cherry picked from commit f446974)
dvsrepo added a commit that referenced this pull request Feb 10, 2022
* 'master' of https://github.com/recognai/rubrix: (26 commits)
  feat(#1061): unify records results title (#1111)
  refactor(#945): using new search service (#1117)
  fix(#1121):  Adjust search bar width (#1124)
  fix(#945): validate label for single label text classification dataset (#1123)
  docs: fix skweak images (#1120)
  fix(#831): Remove sort field when only one is applied (#1116)
  refactor(#945): add current search aggregations as metrics (#1115)
  chore(#982): extends search area (#1112)
  chore(#1054): long records margin adjustment #1114
  feat(#1063): Token Classifier fine tuning content selection (#1084)
  refactor(#1102): remove "Update Summary" button rules summary (#1110)
  refactor(#945): revert index config for text2text (#1108)
  fix: convert pd.NaT to None for event_timestamp (#1105)
  fix(#1094): return empty list for no predicted_as (#1107)
  docs(#1089): remove pip install elasticsearch from docs (#1104)
  fix(#1054): reduce collapsable area. Optimize for annotation (#1106)
  fix(#945): include default aggregations for text2text (#1097)
  refactor(#1044): include last updated field for sort (#1093)
  fix(#1094): remove computed record fields returned in API results (#1095)
  feat(#1051): keep predictions labels when annotating (#1077)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sort] List of records not refreshed when removing sort field
2 participants