Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sort] Allow sort value by event_timestamp or last_updated fields #1835

Closed
frascuchon opened this issue Jan 27, 2022 · 7 comments · Fixed by #1924
Closed

[Sort] Allow sort value by event_timestamp or last_updated fields #1835

frascuchon opened this issue Jan 27, 2022 · 7 comments · Fixed by #1924
Assignees
@leiyre
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: enhancement Indicates new feature requests
Milestone
v1.1.0

Comments

@frascuchon
Copy link
Member

API is ready to sort at least by event_timestamp . So you can proceed for this field. Also , we can tackle the last_updated field to retrieve records sorted by recently updated or created.
@frascuchon frascuchon mentioned this issue Feb 3, 2022
Merged
frascuchon referenced this issue Feb 7, 2022
refactor(#1044): include last updated field for sort (#1093)
60dca5e 
* refactor(API): sort by last_updated field

* test: add tests

* test: fix tests
frascuchon referenced this issue Feb 7, 2022
refactor(#1044): include last updated field for sort (#1093)
1da7d5a 
* refactor(API): sort by last_updated field

* test: add tests

* test: fix tests

(cherry picked from commit 60dca5e)
frascuchon referenced this issue Feb 7, 2022
refactor(#1044): include last updated field for sort (#1093)
961c623 
* refactor(API): sort by last_updated field

* test: add tests

* test: fix tests

(cherry picked from commit 60dca5e)
frascuchon referenced this issue Feb 7, 2022
refactor(#1044): include last updated field for sort (#1093)
fd6603e 
* refactor(API): sort by last_updated field

* test: add tests

* test: fix tests

(cherry picked from commit 60dca5e)
frascuchon referenced this issue Feb 10, 2022
refactor(#1044): include last updated field for sort (#1093)
4a72116 
* refactor(API): sort by last_updated field

* test: add tests

* test: fix tests

(cherry picked from commit 60dca5e)
dvsrepo referenced this issue Feb 10, 2022
@dvsrepo
Merge branch 'master' of https://github.com/recognai/rubrix
8342b51 
* 'master' of https://github.com/recognai/rubrix: (26 commits)
  feat(#1061): unify records results title (#1111)
  refactor(#945): using new search service (#1117)
  fix(#1121):  Adjust search bar width (#1124)
  fix(#945): validate label for single label text classification dataset (#1123)
  docs: fix skweak images (#1120)
  fix(#831): Remove sort field when only one is applied (#1116)
  refactor(#945): add current search aggregations as metrics (#1115)
  chore(#982): extends search area (#1112)
  chore(#1054): long records margin adjustment #1114
  feat(#1063): Token Classifier fine tuning content selection (#1084)
  refactor(#1102): remove "Update Summary" button rules summary (#1110)
  refactor(#945): revert index config for text2text (#1108)
  fix: convert pd.NaT to None for event_timestamp (#1105)
  fix(#1094): return empty list for no predicted_as (#1107)
  docs(#1089): remove pip install elasticsearch from docs (#1104)
  fix(#1054): reduce collapsable area. Optimize for annotation (#1106)
  fix(#945): include default aggregations for text2text (#1097)
  refactor(#1044): include last updated field for sort (#1093)
  fix(#1094): remove computed record fields returned in API results (#1095)
  feat(#1051): keep predictions labels when annotating (#1077)
  ...
@frascuchon frascuchon transferred this issue from argilla-io/argilla May 26, 2022
@frascuchon frascuchon added the area: ui Indicates that an issue or pull request is related to the User Interface (UI) label Jun 29, 2022
@frascuchon frascuchon added type: enhancement Indicates new feature requests area: ui Indicates that an issue or pull request is related to the User Interface (UI) and removed area: ui Indicates that an issue or pull request is related to the User Interface (UI) labels Jul 12, 2022
@dvsrepo
Copy link
Member

dvsrepo commented Nov 4, 2022

This is relevant and should be simple to implement

@frascuchon frascuchon transferred this issue from another repository Nov 7, 2022
@frascuchon frascuchon added this to the v1.1.0 milestone Nov 7, 2022
@Amelie-V
Copy link
Member

Hi @leiyre! do you need something more to proceed with that issue? let me know!

@leiyre
Copy link
Member

leiyre commented Nov 15, 2022

It looks like the API already has the fields, I can handle it

@davidberenstein1957
Copy link
Member

#1911

@davidberenstein1957
Copy link
Member

is this included too perhaps ?

@davidberenstein1957
Copy link
Member

And kind off also relevant IMO.
#1892

@Amelie-V
Copy link
Member

and this one #1849

leiyre added a commit that referenced this issue Nov 18, 2022
@leiyre
feat: Allow sort records by event_timestamp or last_updated fields
036a923 
closes #1835

This PR includes the fields event_timestamp and last_updated in the sort filter allowing to sort records by these values
@leiyre leiyre mentioned this issue Nov 18, 2022
Merged
leiyre added a commit that referenced this issue Nov 21, 2022
@leiyre
feat: Allow sort records by event_timestamp or last_updated fields (#…
1c08c36 
…1924)

* feat: Allow sort records by event_timestamp or last_updated fields

closes #1835

This PR includes the fields event_timestamp and last_updated in the sort filter allowing to sort records by these values

* fix lint

* refactor code

* refactor and clean code after review

* refactor after review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiyre leiyre

Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: enhancement Indicates new feature requests
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

feat: Allow sort records by event_timestamp or last_updated fields argilla-io/argilla
5 participants
@dvsrepo @frascuchon @leiyre @davidberenstein1957 @Amelie-V