New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sort] List of records not refreshed when removing sort field #831
Comments
At the moment this filter is different from the rest, having to click "sort" to confirm the action. @Amelie-V, do you think we can remove the filter directly and maybe add a "remove all" like in the rest? |
El cambio mayor deseable es que no haya que clicar un button de validación (Sort) y que el reorden se haga en tiempo real. |
The To apply change proposed by @Amelie-V I would like to use the X button in a same way like filters do: clear totally the sort configuration and then close modal. If we decide to close the modal every time we click the |
Would it be possible/relevant to add this logic? @frascuchon @dcfidalgo @dvsrepo @leiyre
|
I think the same button should resolve the same action for all cases (clear the Sort configuration) like filter component does. Could you provide a sketch design proposal @Amelie-V ? Anyway, i think It should be better invest the effort to normalize the filter section |
fix #831 This PR allows to remove sort field from cross button when only one is applied
* 'master' of https://github.com/recognai/rubrix: (26 commits) feat(#1061): unify records results title (#1111) refactor(#945): using new search service (#1117) fix(#1121): Adjust search bar width (#1124) fix(#945): validate label for single label text classification dataset (#1123) docs: fix skweak images (#1120) fix(#831): Remove sort field when only one is applied (#1116) refactor(#945): add current search aggregations as metrics (#1115) chore(#982): extends search area (#1112) chore(#1054): long records margin adjustment #1114 feat(#1063): Token Classifier fine tuning content selection (#1084) refactor(#1102): remove "Update Summary" button rules summary (#1110) refactor(#945): revert index config for text2text (#1108) fix: convert pd.NaT to None for event_timestamp (#1105) fix(#1094): return empty list for no predicted_as (#1107) docs(#1089): remove pip install elasticsearch from docs (#1104) fix(#1054): reduce collapsable area. Optimize for annotation (#1106) fix(#945): include default aggregations for text2text (#1097) refactor(#1044): include last updated field for sort (#1093) fix(#1094): remove computed record fields returned in API results (#1095) feat(#1051): keep predictions labels when annotating (#1077) ...
To reproduce:
)
The text was updated successfully, but these errors were encountered: