Skip to content

Commit 4a063f8

Browse files
authored
[CodeQuality] Add missing MinPhpVersionInterface implements on AddNameToBooleanArgumentRector (#7994)
1 parent e7dab26 commit 4a063f8

2 files changed

Lines changed: 15 additions & 2 deletions

File tree

rules/CodeQuality/Rector/CallLike/AddNameToBooleanArgumentRector.php

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,15 @@
1616
use Rector\PHPStan\ScopeFetcher;
1717
use Rector\Rector\AbstractRector;
1818
use Rector\Reflection\ReflectionResolver;
19+
use Rector\ValueObject\PhpVersionFeature;
20+
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
1921
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
2022
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
2123

2224
/**
2325
* @see \Rector\Tests\CodeQuality\Rector\CallLike\AddNameToBooleanArgumentRector\AddNameToBooleanArgumentRectorTest
2426
*/
25-
final class AddNameToBooleanArgumentRector extends AbstractRector
27+
final class AddNameToBooleanArgumentRector extends AbstractRector implements MinPhpVersionInterface
2628
{
2729
public function __construct(
2830
private readonly ReflectionResolver $reflectionResolver,
@@ -81,7 +83,8 @@ public function refactor(Node $node): ?Node
8183
}
8284

8385
$wasChanged = false;
84-
for ($i = $position; $i < count($args); ++$i) {
86+
$counter = count($args);
87+
for ($i = $position; $i < $counter; ++$i) {
8588
$arg = $args[$i];
8689
if ($arg->name instanceof Identifier) {
8790
continue;
@@ -103,6 +106,11 @@ public function refactor(Node $node): ?Node
103106
return $node;
104107
}
105108

109+
public function provideMinPhpVersion(): int
110+
{
111+
return PhpVersionFeature::NAMED_ARGUMENTS;
112+
}
113+
106114
private function shouldSkip(CallLike $callLike): bool
107115
{
108116
if ($callLike->isFirstClassCallable()) {

src/ValueObject/PhpVersionFeature.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -505,4 +505,9 @@ final class PhpVersionFeature
505505
* @see https://wiki.php.net/rfc/clamp_v2
506506
*/
507507
public const int CLAMP = PhpVersion::PHP_86;
508+
509+
/**
510+
* @see https://php.watch/versions/8.0/named-parameters
511+
*/
512+
public const int NAMED_ARGUMENTS = PhpVersion::PHP_80;
508513
}

0 commit comments

Comments
 (0)