[CodeQuality] Skip possibly undefined variable on CoalesceToTernaryRector (#7968)

samsonasik · web-flow · commit 84fe920db62f · 2026-04-11T21:41:03.000+02:00
diff --git a/rules-tests/CodeQuality/Rector/Coalesce/CoalesceToTernaryRector/Fixture/skip_possibly_undefined.php.inc b/rules-tests/CodeQuality/Rector/Coalesce/CoalesceToTernaryRector/Fixture/skip_possibly_undefined.php.inc
@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Coalesce\CoalesceToTernaryRector\Fixture;
+
+class SkipPossiblyUndefined
+{
+    public function run()
+    {
+        if (rand(0, 1)) {
+            $name = 'tom';
+        }
+
+        return $name ?? 'tom';
+    }
+}
diff --git a/rules/CodeQuality/Rector/Coalesce/CoalesceToTernaryRector.php b/rules/CodeQuality/Rector/Coalesce/CoalesceToTernaryRector.php
@@ -8,6 +8,7 @@
 use PhpParser\Node\Expr\ArrayDimFetch;
 use PhpParser\Node\Expr\BinaryOp\Coalesce;
 use PhpParser\Node\Expr\Ternary;
+use PhpParser\Node\Expr\Variable;
 use PHPStan\Type\ErrorType;
 use PHPStan\Type\MixedType;
 use PHPStan\Type\NullType;
@@ -92,6 +93,10 @@ public function refactor(Node $node): ?Node
             }
         }
 
+        if ($node->left instanceof Variable && ! $scope->hasVariableType((string) $this->getName($node->left))->yes()) {
+            return null;
+        }
+
         return new Ternary($node->left, null, $node->right);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@`
`8`	`8`	`use PhpParser\Node\Expr\ArrayDimFetch;`
`9`	`9`	`use PhpParser\Node\Expr\BinaryOp\Coalesce;`
`10`	`10`	`use PhpParser\Node\Expr\Ternary;`
	`11`	`+use PhpParser\Node\Expr\Variable;`
`11`	`12`	`use PHPStan\Type\ErrorType;`
`12`	`13`	`use PHPStan\Type\MixedType;`
`13`	`14`	`use PHPStan\Type\NullType;`
`@@ -92,6 +93,10 @@ public function refactor(Node $node): ?Node`
`92`	`93`	`}`
`93`	`94`	`}`
`94`	`95`
	`96`	`+ if ($node->left instanceof Variable && ! $scope->hasVariableType((string) $this->getName($node->left))->yes()) {`
	`97`	`+ return null;`
	`98`	`+ }`
	`99`	`+`
`95`	`100`	`return new Ternary($node->left, null, $node->right);`
`96`	`101`	`}`
`97`	`102`	`}`