TemplateAnnotationRector adds template name at the end of Route annotation

[stedekay]

Subject	Details
Rector version	v0.5.16
PHP version	PHP 7.3.3
Full Command	vendor/bin/rector process /src --set framework-extra-bundle-50

Current Behaviour

The template name of the Template annotation gets added to the Route annotation.

1) src/PAPP/UserBundle/Controller/FacilityController.php                                                                              
    ---------- begin diff ----------                                                                                                  
--- Original                                                                                                                          
+++ New                                                                                                                               
@@ -35,8 +35,7 @@                                                                                                                          
}

     /**
-     * @Route("/change", name="facility_change")                                                                                     
-     * @Template("PAPPUserBundle:Facility:facility.html.twig")                                                                       
+     * @Route("/change", name="facility_change")("PAPPUserBundle:Facility:facility.html.twig")
      */
     public function changeFacilityAction(): array
@@ -45,9 +44,9 @@                                                                                                                              
         $facilities = $this->facilityRepository->findFacilities();

-        return [                                                                                                                     
+        return $this->render('PAPPUserBundle:Facility:facility.html.twig', [                                                                      
              'facilities' => $facilities,
-        ];                                                                                                                           
+        ]);                                                                                                                              
 }

     /**
    ----------- end diff -----------                                                                                                  
Applied rectors:

 * Rector\Sensio\Rector\FrameworkExtraBundle\TemplateAnnotationRector

Minimal PHP Code Causing Issue

class FacilityController extends DefaultController
{
    /**
     * @var FacilityRepository
     */
    private $facilityRepository;

    public function __construct(FacilityRepository $facilityRepository)
    {
        $this->facilityRepository= $facilityRepository;
    }

    /**
     * @Route("/change", name="facility_change")
     * @Template("PAPPUserBundle:Facility:facility.html.twig")
     */
    public function changeFacilityAction(): array
    {
        $facilities = $this->facilityRepository->findFacilities();

        return [
            'facilities' => $facilities,
        ];
    }
}

Expected Behaviour

1) src/PAPP/UserBundle/Controller/FacilityController.php                                                                              
    ---------- begin diff ----------                                                                                                  
--- Original                                                                                                                          
+++ New                                                                                                                               
@@ -35,8 +35,7 @@                                                                                                                          
}

     /**
      * @Route("/change", name="facility_change")                                                                                     
-     * @Template("PAPPUserBundle:Facility:facility.html.twig")                                                                       
      */
     public function changeFacilityAction(): array
@@ -45,9 +44,9 @@                                                                                                                              
         $facilities = $this->facilityRepository->findFacilities();

-        return [                                                                                                                     
+        return $this->render('PAPPUserBundle:Facility:facility.html.twig', [                                                                      
              'facilities' => $facilities,
-        ];                                                                                                                           
+        ]);                                                                                                                              
 }

     /**
    ----------- end diff -----------                                                                                                  
Applied rectors:

 * Rector\Sensio\Rector\FrameworkExtraBundle\TemplateAnnotationRector

[TomasVotruba]

Hi Stefan,

thanks for the report. I'm looking at it.

[TomasVotruba]

I've added test case and it fails as you say, good 😄

https://github.com/rectorphp/rector/pull/2181/files#diff-a37417d170112374570439d94c834010