Skip to content

Conversation

@jiridanek
Copy link
Member

No description provided.

…ata printouts

Our images are currently named like

    Code Server | Data Science | CPU | Python 3.11

and this is breaking Markdown tables.

- Introduced `escape` function to handle characters affecting Markdown formatting.
- Updated tabular outputs in `package_versions.py` to apply escaping.
- Added unit tests for `escape` function.
@openshift-ci openshift-ci bot requested review from caponetto and jstourac August 28, 2025 12:27
@jiridanek jiridanek changed the title Jd extraimgs xxx [2.23] Jd extraimgs xxx Sep 22, 2025
@jiridanek jiridanek changed the title [2.23] Jd extraimgs xxx [rhoai-2.23] Jd extraimgs xxx Sep 22, 2025
@jiridanek jiridanek changed the title [rhoai-2.23] Jd extraimgs xxx [rhoai-2.23] fix rendering of the supported configurations images table Sep 22, 2025
Copy link
Collaborator

@ide-developer ide-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got an informal check from Ignacio Lago on this

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ide-developer
Once this PR has been reviewed and has the lgtm label, please assign andyatmiami for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek jiridanek merged commit a1d33fb into red-hat-data-services:rhoai-2.23 Sep 22, 2025
12 of 14 checks passed
@jiridanek jiridanek deleted the jd_extraimgs branch September 22, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants