Skip to content

Conversation

@atheo89
Copy link
Member

@atheo89 atheo89 commented Sep 5, 2025

Related to: https://issues.redhat.com/browse/RHAIENG-779
Update .konflux dockerfiles to comply with ARGs

@openshift-ci openshift-ci bot requested review from dibryant and jiridanek September 5, 2025 10:27
@atheo89 atheo89 merged commit 7c50be3 into red-hat-data-services:main Sep 5, 2025
10 of 13 checks passed
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR refactors the Konflux Dockerfiles to use a BASE_IMAGE argument, which is a great improvement for configurability and maintainability. The changes are consistent and well-executed across all modified files.

🔍 General Feedback

  • The use of ARG BASE_IMAGE simplifies the Dockerfiles and removes duplicated logic for handling different architectures and base images.
  • This change makes it much easier to update the base image in the future.
  • The removal of the multi-stage builds for CUDA and ROCm simplifies the Dockerfiles significantly.

Overall, this is a solid improvement to the Dockerfile structure.

@openshift-ci
Copy link

openshift-ci bot commented Sep 5, 2025

@github-actions[bot]: changing LGTM is restricted to collaborators

In response to this:

📋 Review Summary

This PR refactors the Konflux Dockerfiles to use a BASE_IMAGE argument, which is a great improvement for configurability and maintainability. The changes are consistent and well-executed across all modified files.

🔍 General Feedback

  • The use of ARG BASE_IMAGE simplifies the Dockerfiles and removes duplicated logic for handling different architectures and base images.
  • This change makes it much easier to update the base image in the future.
  • The removal of the multi-stage builds for CUDA and ROCm simplifies the Dockerfiles significantly.

Overall, this is a solid improvement to the Dockerfile structure.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: github-actions[bot]
Once this PR has been reviewed and has the lgtm label, please assign daniellutz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89 atheo89 deleted the update-konflux-dockerfiles branch October 13, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant