Skip to content

Conversation

@puneetsharma21
Copy link

@puneetsharma21 puneetsharma21 commented Oct 13, 2025

Synces the following into Dockerfile.konflux

Changes

  • Added the following CMake flags to the PyArrow build:
    • -DARROW_S3=ON → Enables S3 filesystem support for PyArrow.
    • -DARROW_SUBSTRAIT=ON → Enables Substrait support required by Feast

Signed-off-by: puneetsharma21 <puneet.sharma21@ibm.com>
Copy link
Member

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should happen on odh-io/notebooks, I believe. Not directly here.

@atheo89
Copy link
Member

atheo89 commented Oct 13, 2025

Thank you for incorporating the changes on upstream first, I will close this in favor opendatahub-io#2570 the changes will move to downstream on the next nightly sync

@atheo89 atheo89 closed this Oct 13, 2025
@puneetsharma21
Copy link
Author

@jiridanek @atheo89 but the changes are in the Dockerfile.konflux in this PR, the upstream PR was for Dockerfile.cpu opendatahub-io#2570.
For the Konflux Dockerfile file, we’ll need to raise a separate PR.

@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2025

@puneetsharma21: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 569948c link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@atheo89
Copy link
Member

atheo89 commented Oct 17, 2025

thank you for moving the changes to .konflux
/lgtm

Copy link
Member

@atheo89 atheo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek jiridanek merged commit 4ec3d27 into red-hat-data-services:main Oct 17, 2025
15 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants