Skip to content

Conversation

@atheo89
Copy link
Member

@atheo89 atheo89 commented Oct 17, 2025

Description

How Has This Been Tested?

Self checklist (all need to be checked):

  • Ensure that you have run make test (gmake on macOS) before asking for review
  • Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

daniellutz and others added 5 commits October 16, 2025 21:33
* Upgrade packages for latest stable

* Add missing package updates, change manifests and fix tests
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
…nd rstudio nginx (opendatahub-io#2585)

* support odh gateway auth with adjusting code-server and rstudio nginx

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>

* removed redudant fallback location

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>

---------

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
RHOAIENG-35792: disable 2025.1 image for Code Server and Rstudio
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR appears to be a sync of changes from an upstream repository. Based on a review of the included files, the changes are consistent with dependency updates and routine maintenance. No issues were found.

@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2025

@github-actions[bot]: changing LGTM is restricted to collaborators

In response to this:

This PR appears to be a sync of changes from an upstream repository. Based on a review of the included files, the changes are consistent with dependency updates and routine maintenance. No issues were found.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: github-actions[bot]
Once this PR has been reviewed and has the lgtm label, please assign paulovmr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89 atheo89 merged commit 85f8df9 into red-hat-data-services:main Oct 17, 2025
25 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants