-
Notifications
You must be signed in to change notification settings - Fork 22
RHAIENG-1504: incorporate changes to .konflux dockerfiles #1640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There is a problem with the Gemini CLI PR review. Please check the action logs for details. |
|
All set here, I will open a follow up on upstream for this #1500 |
|
@atheo89: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| # hdf5 is needed for h5py | ||
| RUN dnf install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-9.noarch.rpm && \ | ||
| dnf install -y hdf5-devel && \ | ||
| dnf clean all | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I already synced this in
but probably I did not get them all, then.
jiridanek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok over all, but could you recheck the labels change in
jupyter/minimal/ubi9-python-3.12/Dockerfile.konflux.cpu
thanks for taking care of the sync!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks for the review @jiridanek I will move this in to be ready for the code freeze |
https://issues.redhat.com/browse/RHAIENG-1504
Description
These changes were missing on the konflux dockerfiles these changes came from the following upstream PRs:
"protobuf==6.31.1"and monkypatch methods missing in 6.x opendatahub-io/notebooks#2542Follow up PR on upstream: opendatahub-io#2592 for #1500
How Has This Been Tested?
Self checklist (all need to be checked):
make test(gmakeon macOS) before asking for reviewDockerfile.konfluxfiles should be done inodh/notebooksand automatically synced torhds/notebooks. For Konflux-specific changes, modifyDockerfile.konfluxfiles directly inrhds/notebooksas these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria: