Skip to content

Conversation

@atheo89
Copy link
Member

@atheo89 atheo89 commented Oct 17, 2025

https://issues.redhat.com/browse/RHAIENG-1504

Description

These changes were missing on the konflux dockerfiles these changes came from the following upstream PRs:

Follow up PR on upstream: opendatahub-io#2592 for #1500

How Has This Been Tested?

Self checklist (all need to be checked):

  • Ensure that you have run make test (gmake on macOS) before asking for review
  • Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@github-actions
Copy link

There is a problem with the Gemini CLI PR review. Please check the action logs for details.

@jiridanek jiridanek changed the title incorporate changes to .konflux dockerfiles RHAIENG-1504: incorporate changes to .konflux dockerfiles Oct 17, 2025
@atheo89
Copy link
Member Author

atheo89 commented Oct 17, 2025

All set here, I will open a follow up on upstream for this #1500

@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2025

@atheo89: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images b06a26e link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Comment on lines -106 to -110
# hdf5 is needed for h5py
RUN dnf install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-9.noarch.rpm && \
dnf install -y hdf5-devel && \
dnf clean all

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I already synced this in

but probably I did not get them all, then.

Copy link
Member

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok over all, but could you recheck the labels change in

jupyter/minimal/ubi9-python-3.12/Dockerfile.konflux.cpu

thanks for taking care of the sync!

@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89
Copy link
Member Author

atheo89 commented Oct 17, 2025

Thanks for the review @jiridanek I will move this in to be ready for the code freeze

@atheo89 atheo89 merged commit 0957bab into red-hat-data-services:main Oct 17, 2025
24 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants