-
Notifications
You must be signed in to change notification settings - Fork 24
Apply private indexes on minimal workbenches cuda and rocm #1659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply private indexes on minimal workbenches cuda and rocm #1659
Conversation
|
/build-konflux |
|
Folks is not ready, I opened this to run the builds via konflux. At some point it will replace this one #1641 |
Dammm, Red Hat repository URL is denied. The repo name (rhel-9-for-x86_64-baseos-eus-rpms) indicates it’s an EUS repository. EUS repositories require specific subscription entitlements. I will try with the old set of base images till the entitments get enabled from DevOps. |
|
/build-konflux |
985c10f to
74367d5
Compare
|
/build-konflux |
1 similar comment
|
/build-konflux |
61de033 to
ad34cbc
Compare
|
/build-konflux |
ad34cbc to
a3f3123
Compare
|
/build-konflux |
a3f3123 to
2cfdff9
Compare
… it available on runtime
2cfdff9 to
1899c39
Compare
|
/build-konflux |
|
@atheo89: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ysok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that make test will fail because of diff Dockerfile.konflux, I am working on RHAIENG-1603 to parameterize their *.conf files.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek, ysok The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Looks like we can proceed with this, so i'll move this in. thanks for the review and the follow ups steps |
|
/cherrypick rhoai-3.0 |
|
@atheo89: new pull request created: #1671 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
related to: https://issues.redhat.com/browse/RHAIENG-495
Description
This PR includes the production public aipcc indexes on
Minimal CUDA & ROCmworkbenches. Their pylock.toml files have been populated from these indexes as well.The changes have been applied on .konflux flavors so far as the other Dockerfile.cpu get sync via upstream and may create conflict on the upstream syncs.
Notes:
How Has This Been Tested?
Image builds from konflux: (expiration life 5 days)
quay.io/rhoai/pull-request-pipelines@sha256:b363a98acdf12d9a37dc190c3fa4fbe809b82709b858150cc5b7ecfedc298663quay.io/rhoai/pull-request-pipelines@sha256:62b3ea6fb05ebc4c193e9c6277f11a4ff4fec95bfc383dcd8be6d4cf9cefe4dcIntegration in RHOAI 3.0:
sdg_hubSelf checklist (all need to be checked):
make test(gmakeon macOS) before asking for reviewDockerfile.konfluxfiles should be done inodh/notebooksand automatically synced torhds/notebooks. For Konflux-specific changes, modifyDockerfile.konfluxfiles directly inrhds/notebooksas these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria: