Rename data-triton-container and data-triton-root-id #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| module.exports = { | |||
| PAGE_CONTENT_NODE_ID: 'data-triton-content', // Only _one_ of these. | |||
There was a problem hiding this comment.
... but not data-triton-content, data-triton-css or data-triton-link? ;)
There was a problem hiding this comment.
Why do things by halves?
doug-wade
force-pushed
the
rename-data-triton-root-id
branch
from
8ba9182 to
346a755
Compare
doug-wade
force-pushed
the
rename-data-triton-root-id
branch
from
346a755 to
f38c74a
Compare
doug-wade
added a commit
that referenced
this pull request
Mar 10, 2016
Rename data-triton-container and data-triton-root-id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #14