Update Gitops template for RAG DB #21
Conversation
thepetk
left a comment
thepetk
left a comment
There was a problem hiding this comment.
Are we interested to cover cases that require authentication with this PR or is out of scope?
@thepetk currently it is out of scope as this is a direct copy paste of the ai lab recipe. I'll be opening issues for future work regd this. |
templates/http/base/deployment.yaml
Outdated
| runAsNonRoot: true | ||
| runAsNonRoot: true | ||
| {%- if values.dbRequired %} | ||
| - image: {{values.dbContainer}} |
There was a problem hiding this comment.
I thought we were going to run the DB container in a separate pod? FWIW, having the DB separate from the app pod means that the RHOAI workspace can interact with it, without needing the app container to have been built.
There was a problem hiding this comment.
let me check about deploying it by itself
maysunfaisal
force-pushed
the
DEVHAS-673-1
branch
from
9097b62 to
79acf7c
Compare
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
maysunfaisal
force-pushed
the
DEVHAS-673-1
branch
from
79acf7c to
edc5867
Compare
johnmcollier
left a comment
johnmcollier
left a comment
There was a problem hiding this comment.
Just one small nit, otherwise looks good
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| metadata: | ||
| annotations: |
There was a problem hiding this comment.
Nit: tad annotations probably aren't necessary (we don't use it for the RHOAI resources)
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
3 participants
Uh oh!
There was an error while loading. Please reload this page.