Skip to content

Conversation

@maysunfaisal
Copy link
Contributor

@maysunfaisal maysunfaisal commented Jul 30, 2024

Adds the RAG AI Lab Recipe from https://github.com/containers/ai-lab-recipes/tree/main/recipes/natural_language_processing/rag/app

The only update to the content is adding the line RUN chgrp -R 0 /rag && chmod -R g=u /rag to the Containerfile to run on a OCP container.

Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
@maysunfaisal maysunfaisal changed the title Add the rag ai lab recipe Add the RAG AI Lab Recipe Jul 30, 2024
@maysunfaisal maysunfaisal requested a review from yangcao77 July 30, 2024 22:37
Copy link
Contributor

@yangcao77 yangcao77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the script https://github.com/redhat-ai-dev/ai-lab-samples/blob/main/pull-sample-app.sh should also be updated to include the rag sample.

also you will need to create a PR against pdoman ai-lab repo to include the change you made to the containerfile (if haven't done that)

Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
@maysunfaisal maysunfaisal requested a review from yangcao77 August 7, 2024 23:27
@maysunfaisal
Copy link
Contributor Author

maysunfaisal commented Aug 7, 2024

@yangcao77 updated the script and also the recipe repo containers/ai-lab-recipes#716, PTAL

Copy link
Contributor

@yangcao77 yangcao77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maysunfaisal maysunfaisal merged commit f96e4ca into redhat-ai-dev:main Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants