Skip to content

Conversation

@maysunfaisal
Copy link
Contributor

RAG app update to run on vLLM model server

Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
@maysunfaisal maysunfaisal requested a review from yangcao77 August 12, 2024 20:18
Copy link

@johnmcollier johnmcollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should be made in the sample app's repo if possible, like we did for chatbot/codegen

@maysunfaisal
Copy link
Contributor Author

@johnmcollier sorry forgot to link, containers/ai-lab-recipes#750

Copy link
Contributor

@yangcao77 yangcao77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maysunfaisal maysunfaisal merged commit 7f34270 into redhat-ai-dev:main Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants