Skip to content

Conversation

@gabemontero
Copy link
Contributor

@gabemontero gabemontero requested a review from thepetk August 12, 2025 16:18
Copy link
Collaborator

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gabemontero just a quick confirmation that we can merge (in case we need to push a new version of the plugin etc)

@gabemontero
Copy link
Contributor Author

lgtm

@gabemontero just a quick confirmation that we can merge (in case we need to push a new version of the plugin etc)

the bridge's images is already updated @thepetk and is all that is required (no update to the backstage plugins) so when the pod recycles as part of the gitops update, given the deployment has a pull always image pull policy per https://github.com/redhat-ai-dev/ai-rolling-demo-gitops/blob/main/charts/rhdh/templates/rolling-demo-sidecars-job.yaml#L102 it should pick up the new label based route query

@gabemontero
Copy link
Contributor Author

I'll let you hit the merge button @thepetk thanks !!

@thepetk
Copy link
Collaborator

thepetk commented Aug 13, 2025

lgtm
@gabemontero just a quick confirmation that we can merge (in case we need to push a new version of the plugin etc)

the bridge's images is already updated @thepetk and is all that is required (no update to the backstage plugins) so when the pod recycles as part of the gitops update, given the deployment has a pull always image pull policy per https://github.com/redhat-ai-dev/ai-rolling-demo-gitops/blob/main/charts/rhdh/templates/rolling-demo-sidecars-job.yaml#L102 it should pick up the new label based route query

Thanks for sharing @gabemontero !

@thepetk thepetk merged commit 0488e92 into redhat-ai-dev:main Aug 13, 2025
@gabemontero gabemontero deleted the rm-model-registry-route-setting branch August 13, 2025 13:57
@thepetk
Copy link
Collaborator

thepetk commented Aug 13, 2025

@gabemontero the application is now synced and I see things are running smoothly

@gabemontero
Copy link
Contributor Author

@gabemontero the application is now synced and I see things are running smoothly

Awesome thanks for letting me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants