Skip to content

RHDHPAI-1028: Reorganize RBAC for additional permissions #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 20, 2025
Merged

RHDHPAI-1028: Reorganize RBAC for additional permissions #31

merged 7 commits into from
Aug 20, 2025

Conversation

@michael-valdron
Copy link
Contributor

@michael-valdron michael-valdron commented Aug 1, 2025 •
edited
Loading

ref: https://issues.redhat.com/browse/RHDHPAI-1028

Consolidates user groups into a new redhat-ai-dev-users Group referenced under redhat-ai-dev-view ClusterRoleBinding

Consolidates user groups into a new redhat-ai-dev-view-users Group to provide cluster-wide view permissions to specified users via redhat-ai-dev-view ClusterRoleBinding.

Add rhoai-workspace-edit RoleBinding

Adds rhoai-workspace-edit RoleBinding that references the redhat-ai-dev-users Group to edit anything under the rhoai-workspace.

Remove redhat-ai-dev-edit ClusterRoleBinding and redhat-ai-dev-edit-users Group

Removes redhat-ai-dev-edit ClusterRoleBinding and redhat-ai-dev-edit-users Group to narrow the permissions to redhat-ai-dev users to just the permissions needed. With the changes above, these larger scope of permissions are no longer needed.

Update authorization README file

Update authorization/README.md with the changes above.

@michael-valdron
add rhoai-workspace namespace edit Group and RoleBinding
ea06743 
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
fix: correct Group reference to 'redhat-ai-dev-view-users' under 'red…
141cb4f 
…hat-ai-dev-vview' ClusterRoleBinding

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
update group permissions under authorization README file
3a59036 
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
johnmcollier
johnmcollier requested changes Aug 1, 2025
View reviewed changes
Copy link
Contributor

@johnmcollier johnmcollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on Michael! I've left a couple comments.

Let's also hold off on merging til https://github.com/redhat-ai-dev/rosa-namespace-provisioner/ is updated, as we'll need the changes in it (granting edit permissions to user's in their personal namespace) first.

@michael-valdron
feedback: consolidate user groups to 'redhat-ai-dev-users' with only …
18674f9 
…'redhat-ai-dev-view' ClusterRoleBinding

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
feedback: reference 'redhat-ai-dev-users' Group under 'rhoai-workspac…
80281ef 
…e-edit' RoleBinding

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
update README with revisions
f7f392a 
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
johnmcollier
johnmcollier approved these changes Aug 1, 2025
View reviewed changes
Copy link
Contributor

@johnmcollier johnmcollier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor comment. But as I mentioned, let's hold off on merging til https://github.com/redhat-ai-dev/rosa-namespace-provisioner/ is updated

@michael-valdron
Copy link
Contributor Author

michael-valdron commented Aug 14, 2025

Looks good, just one minor comment. But as I mentioned, let's hold off on merging til https://github.com/redhat-ai-dev/rosa-namespace-provisioner/ is updated

@johnmcollier Got the changes open here: redhat-ai-dev/rosa-namespace-provisioner#4

@michael-valdron
feedback: clarify edit permissions to personal user namespaces under …
e23b250 
…README

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
Copy link
Contributor Author

michael-valdron commented Aug 19, 2025

@johnmcollier With redhat-ai-dev/rosa-namespace-provisioner#4 its safe to now merge this PR?

johnmcollier
johnmcollier approved these changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@johnmcollier johnmcollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM let's merge

@michael-valdron michael-valdron merged commit 1a78ac1 into redhat-ai-dev:main Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnmcollier johnmcollier johnmcollier approved these changes

@thepetk thepetk Awaiting requested review from thepetk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michael-valdron @johnmcollier