Skip to content

Conversation

@alkakumari016
Copy link
Contributor

downstream the support for custom labels for configmap and secret created by rollout manager

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:
This PR downstreams the support for adding custom labels for configmap and secret created by rollout manager.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?
https://issues.redhat.com/browse/GITOPS-7349
Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci
Copy link

openshift-ci bot commented Nov 5, 2025

Hi @alkakumari016. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@svghadi
Copy link
Member

svghadi commented Nov 5, 2025

/ok-to-test

@alkakumari016
Copy link
Contributor Author

/retest

…ated by argo-rollout

Signed-off-by: Alka Kumari <alkumari@redhat.com>
@alkakumari016
Copy link
Contributor Author

/retest

@svghadi
Copy link
Member

svghadi commented Nov 7, 2025

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 7, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit ad62d76 into redhat-developer:master Nov 7, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants