Skip to content

Conversation

@anandf
Copy link
Member

@anandf anandf commented Aug 26, 2024

What type of PR is this?
/kind bug

What does this PR do / why we need it:
Upgraded ArgoCD Operator and ArgoCD to pick up the fix related to ArgoCD UI broken when the route API becomes unavailable momentarily.

When there is an issue with the API server pods, or the API server pods are just coming up after a restart, the current check for API availability done with a discovery client will fail. This makes the operator code to assume that the server does not support the Route API. To fix this, whenever the API availability check fails, the operator checks if the API is registered. If registered, then the operator assumes that the Route API is supported in the cluster and would eventually become available.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes https://issues.redhat.com/browse/GITOPS-4358

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

… not reachable

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
@openshift-ci openshift-ci bot requested review from chetan-rns and jgwest August 26, 2024 13:20
Copy link
Member

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@anandf
Copy link
Member Author

anandf commented Sep 16, 2024

/retest

@anandf
Copy link
Member Author

anandf commented Sep 16, 2024

/approve

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Sep 16, 2024
@openshift-ci
Copy link

openshift-ci bot commented Sep 16, 2024

@anandf: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gitops-ocp4.14-lp-interop-images 6d14782 link true /test gitops-ocp4.14-lp-interop-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@svghadi
Copy link
Member

svghadi commented Oct 2, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Oct 2, 2024
@openshift-ci
Copy link

openshift-ci bot commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anandf, svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 46df536 into redhat-developer:v1.12 Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants