downstream ImagePullPolicy feature #993
Conversation
Signed-off-by: Alka Kumari <alkumari@redhat.com>
|
Hi @alkakumari016. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Signed-off-by: Alka Kumari <alkumari@redhat.com>
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
olivergondza
left a comment
olivergondza
left a comment
There was a problem hiding this comment.
Added some comments, mostly on the test side.
| Eventually(ss3, "3m", "5s").Should(k8sFixture.ExistByName()) | ||
|
|
||
| Eventually(func() bool { | ||
| err := k8sClient.Get(ctx, client.ObjectKey{Name: "argocd-application-controller", Namespace: ns3.Name}, ss3) |
There was a problem hiding this comment.
Please extract this into reusable helper functions, it is used repeatedly.
There was a problem hiding this comment.
Hey @olivergondza thanks for the comments, I have added few changes.
test/openshift/e2e/ginkgo/sequential/1-114_validate_imagepullpolicy_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Alka Kumari <alkumari@redhat.com>
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: svghadi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 0f46891
into
redhat-developer:master
4 participants
What type of PR is this?
What does this PR do / why we need it:
downstream ImagePullPolicy feature
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
https://issues.redhat.com/browse/GITOPS-7732
Test acceptance criteria:
How to test changes / Special notes to the reviewer: