Skip to content

Conversation

@akhilnittala
Copy link
Contributor

@akhilnittala akhilnittala commented Nov 4, 2025

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug

/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:
Reported a significant startup delay, approximately 13 minutes, for HA server zero due to the config init container for Redis hanging while attempting to identify the Redis master, a problem stemming from the lack of a connection timeout flag in the current Redis version. To resolve this, proposed and demonstrated a fix involving adding a 3-second timeout command before redis-cli, which agreed to implement in both the GitOps and Argo CD operators.
Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:
https://issues.redhat.com/browse/GITOPS-7608
Fixes #?
https://issues.redhat.com/browse/GITOPS-7608
Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

  • deploy openshift gitops operator on oc cluster with multi node
  • edit the default instance of argocd from spec.ha.enabled: false to spec.ha.enabled: true
  • verify the time taking for redis related ha proxy pod and ha-server pods

@openshift-ci openshift-ci bot added the kind/bug Something isn't working label Nov 4, 2025
@openshift-ci openshift-ci bot requested review from jgwest and svghadi November 4, 2025 04:07
@svghadi
Copy link
Member

svghadi commented Nov 4, 2025

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 4, 2025
@svghadi
Copy link
Member

svghadi commented Nov 4, 2025

/cherry-pick v1.18

@openshift-cherrypick-robot

@svghadi: once the present PR merges, I will cherry-pick it on top of v1.18 in a new PR and assign it to you.

In response to this:

/cherry-pick v1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@svghadi
Copy link
Member

svghadi commented Nov 4, 2025

/cherry-pick v1.17

@openshift-cherrypick-robot

@svghadi: once the present PR merges, I will cherry-pick it on top of v1.17 in a new PR and assign it to you.

In response to this:

/cherry-pick v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@svghadi
Copy link
Member

svghadi commented Nov 4, 2025

/retest

@akhilnittala
Copy link
Contributor Author

/retest-required

@varshab1210
Copy link
Member

/test unit

Signed-off-by: akhil nittala <nakhil@redhat.com>
@svghadi svghadi force-pushed the usr/akhil/GITOPS-7608 branch from c509e7d to 1e4326b Compare November 5, 2025 03:21
@openshift-ci openshift-ci bot removed the lgtm label Nov 5, 2025
@akhilnittala
Copy link
Contributor Author

/retest-required

1 similar comment
@akhilnittala
Copy link
Contributor Author

/retest-required

@svghadi
Copy link
Member

svghadi commented Nov 6, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 6, 2025
@akhilnittala
Copy link
Contributor Author

/retest-required

1 similar comment
@akhilnittala
Copy link
Contributor Author

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit f706d31 into redhat-developer:master Nov 6, 2025
16 checks passed
@openshift-cherrypick-robot

@svghadi: new pull request created: #1001

In response to this:

/cherry-pick v1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@svghadi: new pull request created: #1002

In response to this:

/cherry-pick v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved kind/bug Something isn't working lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants