-
Notifications
You must be signed in to change notification settings - Fork 343
Convert Kuttl test 1-098_validate_dex_clientsecret to Ginkgo test format #997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Kuttl test 1-098_validate_dex_clientsecret to Ginkgo test format #997
Conversation
|
@Naveena-058: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @Naveena-058. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
…e3f987ad440589838c7a3' (redhat-developer#994) * Update to latest commit of argo-rollouts-manager '4619e3168941619f554e3f987ad440589838c7a3' Signed-off-by: Jonathan West <jonwest@redhat.com> * Log additional debug logs on failure of 1-040 Signed-off-by: Jonathan West <jonwest@redhat.com> * chore: Move parallelizable tests to parallel Signed-off-by: Jonathan West <jonwest@redhat.com> * chore: increase Ginkgo sequential timeout slightly: Signed-off-by: Jonathan West <jonwest@redhat.com> --------- Signed-off-by: Jonathan West <jonwest@redhat.com> Signed-off-by: NAVEENA S <nas@redhat.com>
Signed-off-by: NAVEENA S <nas@redhat.com>
0260752 to
90a4905
Compare
…t-deprecated Resolve merge conflicts and bring branch up to date with master Signed-off-by: NAVEENA S <nas@redhat.com>
|
/retest |
svghadi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: svghadi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
6f1f3d0
into
redhat-developer:master
What type of PR is this?
/kind code-refactoring
What does this PR do / why we need it:
Changes:
1-098_validate_dex_clientsecret_deprecated.goHave you updated the necessary documentation?
Which issue(s) this PR fixes:
Part of Kuttl to Ginkgo migration effort
Fixes #?
https://issues.redhat.com/browse/GITOPS-7205
Test acceptance criteria:
How to test changes / Special notes to the reviewer: