Skip to content

Conversation

@Naveena-058
Copy link
Contributor

What type of PR is this?
/kind code-refactoring

What does this PR do / why we need it:
Changes:

  • Converts Kuttl test to Ginkgo format: 1-098_validate_dex_clientsecret_deprecated.go
  • Maintains the same test functionality: validates dex client secret is properly copied from service account token to argocd-secret
  • Uses proper Ginkgo/Gomega patterns and fixtures (argocdFixture, k8sFixture, fixtureUtils)
  • Implements parallel test structure with proper namespace isolation and cleanup
  • Follows existing codebase patterns and conventions

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:
Part of Kuttl to Ginkgo migration effort

Fixes #?
https://issues.redhat.com/browse/GITOPS-7205

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci
Copy link

openshift-ci bot commented Nov 5, 2025

@Naveena-058: The label(s) kind/code-refactoring cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind code-refactoring

What does this PR do / why we need it:
Changes:

  • Converts Kuttl test to Ginkgo format: 1-098_validate_dex_clientsecret_deprecated.go
  • Maintains the same test functionality: validates dex client secret is properly copied from service account token to argocd-secret
  • Uses proper Ginkgo/Gomega patterns and fixtures (argocdFixture, k8sFixture, fixtureUtils)
  • Implements parallel test structure with proper namespace isolation and cleanup
  • Follows existing codebase patterns and conventions

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:
Part of Kuttl to Ginkgo migration effort

Fixes #?
https://issues.redhat.com/browse/GITOPS-7205

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link

openshift-ci bot commented Nov 5, 2025

Hi @Naveena-058. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@varshab1210
Copy link
Member

/ok-to-test

jgwest and others added 2 commits November 6, 2025 15:36
…e3f987ad440589838c7a3' (redhat-developer#994)

* Update to latest commit of argo-rollouts-manager '4619e3168941619f554e3f987ad440589838c7a3'

Signed-off-by: Jonathan West <jonwest@redhat.com>

* Log additional debug logs on failure of 1-040

Signed-off-by: Jonathan West <jonwest@redhat.com>

* chore: Move parallelizable tests to parallel

Signed-off-by: Jonathan West <jonwest@redhat.com>

* chore: increase Ginkgo sequential timeout slightly:

Signed-off-by: Jonathan West <jonwest@redhat.com>

---------

Signed-off-by: Jonathan West <jonwest@redhat.com>
Signed-off-by: NAVEENA S <nas@redhat.com>
@Naveena-058 Naveena-058 force-pushed the ginkgo-test-1-098-validate-dex-clientsecret-deprecated branch from 0260752 to 90a4905 Compare November 6, 2025 10:07
…t-deprecated

Resolve merge conflicts and bring branch up to date with master

Signed-off-by: NAVEENA S <nas@redhat.com>
@alkakumari016
Copy link
Contributor

/retest

Copy link
Member

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@svghadi
Copy link
Member

svghadi commented Nov 10, 2025

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved and removed lgtm labels Nov 10, 2025
@svghadi
Copy link
Member

svghadi commented Nov 10, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 10, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 6f1f3d0 into redhat-developer:master Nov 10, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants