Skip to content

feat: supporting scanning requirements.txt #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zvigrinberg merged 1 commit into from
Oct 23, 2023
Merged

feat: supporting scanning requirements.txt #136

zvigrinberg merged 1 commit into from
Oct 23, 2023

Conversation

@xieshenzh
Copy link
Collaborator

@xieshenzh xieshenzh commented Oct 13, 2023

Support scanning dependency vulnerabilities in requirements.txt.

@xieshenzh xieshenzh force-pushed the python-requirements branch from 4ccc307 to eee3c3f Compare October 14, 2023 04:43
@xieshenzh
Copy link
Collaborator Author

xieshenzh commented Oct 17, 2023

@zvigrinberg @ilan-pinto please review this PR for python.
This PR also contains commits from the PR for Go: #134
I'll rebase the PR once the PR for Go is merged.

@xieshenzh xieshenzh mentioned this pull request Oct 17, 2023
Merged
@xieshenzh xieshenzh force-pushed the python-requirements branch from eee3c3f to 8e17117 Compare October 23, 2023 15:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@zvigrinberg
Copy link
Collaborator

zvigrinberg commented Oct 23, 2023

Hi @xieshenzh
I Saw that you're performing some changes in the PR. kindly let me know when you're done so i'll be able to review and approve this PR, Thanks.

@xieshenzh xieshenzh marked this pull request as ready for review October 23, 2023 15:25
@xieshenzh
Copy link
Collaborator Author

xieshenzh commented Oct 23, 2023

Hi @xieshenzh I Saw that you're performing some changes in the PR. kindly let me know when you're done so i'll be able to review and approve this PR, Thanks.

Thanks @zvigrinberg . I have rebased this PR, and it is ready for review now.

zvigrinberg
zvigrinberg approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@zvigrinberg zvigrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, approved.

@zvigrinberg zvigrinberg merged commit 092298c into redhat-developer:main Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zvigrinberg zvigrinberg zvigrinberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xieshenzh @zvigrinberg