fix: Download LSP bundle with nodejs runtime #26

arajkumar · 2021-02-08T13:20:35Z

This PR eliminates the need to have nodejs runtime on the developer machine. It is just a first step towards making IJ analytics plugin in sync with it's vscode counterpart.

Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>

gradle.properties

jeffmaury · 2021-02-08T14:45:38Z

.github/workflows/IJ.yml

    strategy:
      matrix:
-        IJ: [IC-2018.1, IC-2018.2, IC-2018.3, IC-2019.1, IC-2019.2, IC-2019.3, IC-2020.1, IC-2020.2, IC-2020.3]
+        IJ: [IC-2019.1, IC-2019.2, IC-2019.3, IC-2020.1, IC-2020.2, IC-2020.3]


What is the rationale for removing those versions ?

Because those weren't supporting new APIs Service and PersistentState. Do we really need to support those old versions as well?

We will add telemetry that will give use versions of IJ that are just. Before that, keep current state

@jeffmaury how about keep the supported version in sync with tekton? That seems reasonable to me. WDTY?
https://github.com/redhat-developer/intellij-tekton/blob/master/.github/workflows/IJ.yml#L17

As I told you, the motivation to change supported version will be based on telemetry. Let me know if you can't cope with the current state and I will do the job to adapt your PR

jeffmaury · 2021-02-08T14:47:35Z

src/main/java/org/jboss/tools/intellij/analytics/Platform.java

+    this.lspBundleName = lspBundleName;
+  }
+
+  static Platform detect(Properties systemProperties) {


Not required, IntelliJ SDK provides com.intellij.openapi.util.SystemInfo

jeffmaury · 2021-02-08T14:50:45Z

src/main/resources/META-INF/plugin.xml

    <externalAnnotator id="LSPAnnotator-xml" language="XML" implementationClass="org.wso2.lsp4intellij.contributors.annotator.LSPAnnotator"/>
    <externalAnnotator id="LSPAnnotator-json" language="JSON" implementationClass="org.wso2.lsp4intellij.contributors.annotator.LSPAnnotator"/>
    <externalAnnotator id="LSPAnnotator-txt" language="TEXT" implementationClass="org.wso2.lsp4intellij.contributors.annotator.LSPAnnotator"/>
+    <postStartupActivity implementation="org.jboss.tools.intellij.analytics.PostStartupActivity"/>


The reason for having it implemented as application component is that postStartupActivity is delayed and thus if you have opened documents when you open a project, the LSP may not be started.

It works. Also intellij doc says application component is deprecated.

https://plugins.jetbrains.com/docs/intellij/plugin-components.html

Yes but deprecated does not mean removed. So my concern is that if the file is already opened then seems the LSP is started but I can't see the decorations on the file.

@jeffmaury I see similar issue even without this change. Can you just try adding a dummy line in the manifest to see whether it could decorate? it is a bug for sure, just want to check.

Not sure to understand. If I comment this line out, then LSP won't be started at all. So If this is like before then we're good.

Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>

src/main/resources/META-INF/plugin.xml

Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>

.github/workflows/IJ.yml

jeffmaury · 2021-02-15T09:30:32Z

build.gradle

 //LSP plugin causes this task to fail
 buildSearchableOptions.enabled = false

-task downloadFile(type: Download) {


The download plugin must be removed as well

src/main/java/org/jboss/tools/intellij/analytics/AnalyticsPersistentSettings.java

jeffmaury · 2021-02-15T09:45:18Z

Also while testing it, I got the following error:

java.lang.NullPointerException
	at org.jboss.tools.intellij.analytics.LSPBundle.isNewRelease(LSPBundle.java:73)
	at org.jboss.tools.intellij.analytics.LSPBundle.downloadIfNeeded(LSPBundle.java:80)
	at org.jboss.tools.intellij.analytics.LSPBundle$1.run(LSPBundle.java:62)
	at com.intellij.openapi.progress.impl.CoreProgressManager$TaskRunnable.run(CoreProgressManager.java:888)
	at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcess$2(CoreProgressManager.java:163)
	at com.intellij.openapi.progress.impl.CoreProgressManager.registerIndicatorAndRun(CoreProgressManager.java:585)
	at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:531)
	at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:59)
	at com.intellij.openapi.progress.impl.CoreProgressManager.runProcess(CoreProgressManager.java:150)
	at com.intellij.openapi.progress.impl.CoreProgressManager$4.lambda$run$0(CoreProgressManager.java:402)
	at com.intellij.util.ConcurrencyUtil.runUnderThreadName(ConcurrencyUtil.java:221)
	at com.intellij.openapi.progress.impl.CoreProgressManager$4.run(CoreProgressManager.java:402)
	at com.intellij.openapi.application.impl.ApplicationImpl$1.run(ApplicationImpl.java:238)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>

arajkumar · 2021-02-17T11:53:22Z

@jeffmaury rebased and kept 2020.1 as minimum support IJ version. PTAL

jeffmaury

Last piece before we can merge: remove the download plugin from build.gradle

jeffmaury · 2021-02-17T11:57:25Z

build.gradle

 plugins {
    id "org.jetbrains.intellij" version "0.4.21"
-	id 'de.undercouch.download' version '3.4.3'
+    id 'de.undercouch.download' version '3.4.3'


To be removed

Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>

sonarqubecloud · 2021-02-17T12:36:36Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

jeffmaury

LGTM

initial changes to download bundled lsp from GH release page

e9b8434

Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>

arajkumar force-pushed the download-bundled-lsp branch from 7de6c1b to e9b8434 Compare February 8, 2021 13:24

No longer supports 2018 IJ

f2a9884

Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>

jeffmaury requested changes Feb 8, 2021

View reviewed changes

fix: Use ij util for platform detection

8d09142

Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>

arajkumar force-pushed the download-bundled-lsp branch from e63e3b9 to 8d09142 Compare February 9, 2021 10:02

jeffmaury reviewed Feb 10, 2021

View reviewed changes

src/main/resources/META-INF/plugin.xml Show resolved Hide resolved

jeffmaury reviewed Feb 10, 2021

View reviewed changes

src/main/resources/META-INF/plugin.xml Outdated Show resolved Hide resolved

bit more cleanup and support 2019.3

b3048cf

Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>

arajkumar force-pushed the download-bundled-lsp branch from 4bff267 to b3048cf Compare February 11, 2021 13:22

arajkumar requested a review from jeffmaury February 11, 2021 13:25

arajkumar force-pushed the download-bundled-lsp branch from 3313c4e to f4726c6 Compare February 15, 2021 06:24

jeffmaury requested changes Feb 15, 2021

View reviewed changes

fix: Minimum support IJ is 2020.1

d89fbb8

Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>

arajkumar force-pushed the download-bundled-lsp branch from f4726c6 to d89fbb8 Compare February 17, 2021 11:23

arajkumar added 3 commits February 17, 2021 17:14

fix: use 201 as the min supported sdk

5e6ed97

Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>

fix: extract lsp registration out of LSPBundle

a8fc011

Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>

Merge remote-tracking branch 'origin/master' into download-bundled-lsp

017aad1

Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>

arajkumar requested a review from jeffmaury February 17, 2021 11:52

jeffmaury requested changes Feb 17, 2021

View reviewed changes

fix: remove unused gradle plugin

780d225

Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>

arajkumar requested a review from jeffmaury February 17, 2021 12:25

fix: Remove nodejs requirment section from README.md

14cda1a

Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>

jeffmaury approved these changes Feb 19, 2021

View reviewed changes

jeffmaury merged commit daf877c into redhat-developer:master Feb 19, 2021

fix: Download LSP bundle with nodejs runtime #26

fix: Download LSP bundle with nodejs runtime #26

Uh oh!

Conversation

arajkumar commented Feb 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arajkumar Feb 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jeffmaury commented Feb 15, 2021

Uh oh!

arajkumar commented Feb 17, 2021

Uh oh!

jeffmaury left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 17, 2021

Uh oh!

jeffmaury left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

arajkumar commented Feb 8, 2021 •

edited

Loading

arajkumar Feb 11, 2021 •

edited

Loading