snc: use awscli container image in cloud-config #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of downloading and extracting the awscli from the released zip using the container image is faster
this updates the command to check the cluster using either of the two kubeconfig files: /opt/kubeconfig and /opt/crc/kubeconfig during cert rotation the /opt/crc/kubeconfig file is created first and copied to /opt/kubeconfig, but the service might fail before the copy happens, so this ensures that we check using both kubeconfigs
adrianriobo
reviewed
Aug 5, 2025
| - podman run -it --rm --workdir /data --privileged -v ${PWD}:/data registry.access.redhat.com/ubi9/toolbox unzip awscliv2.zip | ||
| - ./aws/install | ||
| - export PS=$(aws ssm get-parameter --name "{{ .SSMPullSecretName }}" --with-decryption --query "Parameter.Value" --output text) | ||
| - export PS=$(podman run --rm docker.io/amazon/aws-cli ssm get-parameter --name "{{ .SSMPullSecretName }}" --with-decryption --query "Parameter.Value" --output text) |
There was a problem hiding this comment.
Did you test this? are the creds picked as expected from the container?
There was a problem hiding this comment.
yes, this was tested and working
| NamePrefix: pulumi.String(r.ID), | ||
| ImageId: pulumi.String(r.AMI.Id), | ||
| KeyName: r.KeyResources.AWSKeyPair.KeyName, | ||
| EbsOptimized: pulumi.String("true"), |
There was a problem hiding this comment.
nice this will be used then across all targets on aws
adrianriobo
approved these changes
Aug 5, 2025
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.