fix: aws public subnet extra Eip #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When provisioning a public subnet it can create a NatGateway, the NatGateway requires an EIP which was created even when the NatGateway was not needed, this commit creates the Eip only if NatGateway is required Signed-off-by: Adrian Riobo <ariobolo@redhat.com>
flacatus
approved these changes
Aug 20, 2025
|
Tested this PR, the EIP is successfully deleted with the decommission job |
lilyLuLiu
approved these changes
Aug 20, 2025
this commit increased the number of types when chekcing types by args from 15 to 20 anf the number of types to be used for bid from 5 to 8. This should ensure even more stability to the spot calculations Signed-off-by: Adrian Riobo <ariobolo@redhat.com>
when non spot based on args at least 1 Az will have supported types, we ensure the random Az at least has one, if non spot is instance type based it may possible non Az has supported types under that circumstance it will return error Signed-off-by: Adrian Riobo <ariobolo@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When provisioning a public subnet it can create a NatGateway, the NatGateway requires an EIP which was created even when the NatGateway was not needed, this commit creates the Eip only if NatGateway is required