-
Notifications
You must be signed in to change notification settings - Fork 2
Packaging updates #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kdvalin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move test dependent packages to their own files, and keep common dependencies in hammerdb.json
kdvalin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
malucius-rh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Adds a call to the package_tool utility, so the wrapper installs the required packages.
Before/After Comparison
Before: Wrapper depended on the user or Zathras to install the packages for it.
After: The wrapper will now install the packages it requires to run
Clerical Stuff
This closes #43
Relates to JIRA: RPOPC-664
Testing:
Tested on RHEL only as that is all we support this wrapper on at this time.