Use new package dependency system #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves all the requirenments that this wrapper needs for pip and system packages to `pyperf.json`, except for pyperformance which is added within pyperf_run script. The reason for that is to allow for the user to specify the version of pyperformance to run. Bug: This only works for the default python3 package for most OS types, more effort will be needed to deal with different python versions that are not the default python3 binary.
Revert SUSE packages due to SLES missing from current package_tool support. Additionally the default shipped version of python3 is 3.6 in SLES, which does not support currently used pyperformance version This reverts commit 28b3dc7.
Moves the python packages to their own dependency files so different packages can be provided for different intepreters. Additionally if the OS isn't supported for a specified python binary (like SLES and python3) we can leave it blank and then catch the error before getting obtuse error messages.
Add python3-lib2to3 to dependencies for Ubuntu. This is applicable to all other python binaries that may be used.
Respects the `--no_packages` flag now, skipping pip installs and other system packages required by the wrapper.
|
This relates to RPOPC-652 |
dvalinrh
added
the
group_review_lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves package dependency information from zathras's local configurations to the wrapper so the dependencies can be versioned with the wrapper.
Before/After Comparison
Before
Wrapper dependencies were either managed through zathras, which could be disconnected from the wrapper version requirements, or managed manually.
After
Wrapper dependencies are managed in
pyperf.jsonand other JSON files for assorted python versions and installed throughpackage_toolintest_tool-wrappers. This keeps the versioning with the wrapper repo and with the code that requires the dependencies.OS's tested (test runs on a fresh AWS instance)
SLES(Was not supported before this PR)Clerical Stuff
This closes #51
Relates to JIRA: RPOPC-652