fix: titleSs() handles apostrophes correctly, see #453

str.title() treats apostrophes as word boundaries, capitalizing
the following letter (e.g. "page's title" became "Page'S Title").
Apply the same magicword workaround used for 'ß' so apostrophes
are preserved as in-word characters.

This issue was reported in #453.

Author: redimp

otterwiki/util.py

@@ -116,16 +116,27 @@ def split_path(path: str) -> List[str]:
 
 def titleSs(s):
     """
-    This function is a workaround for str.title() not knowing uppercase 'ß'.
+    This function is a workaround for str.title() not knowing uppercase 'ß'
+    and treating the apostrophe as a word boundary.
     """
-    if 'ß' not in s:
-        return s.title()
-    _magicword = 'M🙉A🙈G🙊I🐤C🐣W🐥O🦆R🐔D'
-    while _magicword in s:
-        _magicword = 2 * _magicword
-    s = s.replace('ß', _magicword)
+    _eszett = ''
+    if 'ß' in s:
+        _eszett = 'E🙉S🙈Z🙊E🐤T🐣T'
+        while _eszett in s:
+            _eszett = 2 * _eszett
+        s = s.replace('ß', _eszett)
+    _apostrophe = ''
+    if "'" in s:
+        _apostrophe = 'A🙉P🙈O🙊S🐤T🐣R🐥O🦆P🐔H🦜E'
+        while _apostrophe in s:
+            _apostrophe = 2 * _apostrophe
+        s = s.replace("'", _apostrophe)
     s = s.title()
-    return re.sub(re.escape(_magicword), 'ß', s, flags=re.IGNORECASE)
+    if _eszett:
+        s = re.sub(re.escape(_eszett), 'ß', s, flags=re.IGNORECASE)
+    if _apostrophe:
+        s = re.sub(re.escape(_apostrophe), "'", s, flags=re.IGNORECASE)
+    return s
 
 
 def get_pagepath(pagename):

tests/test_util.py

@@ -169,6 +169,9 @@ def test_titleSs():
     )
     assert "\"Foobarß\"" == titleSs("\"foobarß\"")
     assert "Foobarß" == titleSs("foobarß")
+    assert "Page's Title" == titleSs("page's title")
+    assert "Don't Stop" == titleSs("don't stop")
+    assert "It's Foobarß" == titleSs("it's foobarß")
 
 
 def test_patchset2filedict():