Test/issue 116 async blob access #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds comprehensive regression tests for Issue #116 where AsyncRedisSaver would raise AttributeError when accessing blob attributes in _abatch_load_pending_sends. Tests verify: - Correct handling of $.blob JSON path attribute syntax - Graceful fallback when blob attributes are missing - Proper mocking of Redis Document responses These tests would have caught the bug fixed in PR #117.
Fixes type error where _task could be None but was being awaited without proper type guard. Added explicit None check before calling .done() and awaiting the task. Resolves mypy error: Incompatible types in 'await' (actual type 'Task[Any] | None', expected type 'Awaitable[Any]')
…rnings Test functions were returning boolean values which caused pytest warnings: 'Test functions should return None'. Updated all test functions to only use assertions without returning values. Updated main() to handle the new pattern with try/except instead of checking return values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.