Skip to content

Added fix for homebrew release flow #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2025
Merged

Added fix for homebrew release flow #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions src/redis_release/bht/behaviours.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,18 +806,22 @@ def update(self) -> Status:
pass
else:
assert self.release_version is not None
if self.release_version.is_internal:
self.package_meta.release_type = ReleaseType.INTERNAL
self.package_meta.homebrew_channel = HomebrewChannel.RC
else:
if self.package_meta.release_type is None:
if self.release_version.is_internal:
self.package_meta.release_type = ReleaseType.INTERNAL
else:
if self.release_version.is_ga:
self.package_meta.release_type = ReleaseType.PUBLIC
elif self.release_version.is_rc:
self.package_meta.release_type = ReleaseType.PUBLIC
else:
self.package_meta.release_type = ReleaseType.INTERNAL

if self.package_meta.homebrew_channel is None:
if self.release_version.is_ga:
self.package_meta.release_type = ReleaseType.PUBLIC
self.package_meta.homebrew_channel = HomebrewChannel.STABLE
elif self.release_version.is_rc:
self.package_meta.release_type = ReleaseType.PUBLIC
self.package_meta.homebrew_channel = HomebrewChannel.RC
else:
self.package_meta.release_type = ReleaseType.INTERNAL
# RC, internal, or any other version goes to RC channel
self.package_meta.homebrew_channel = HomebrewChannel.RC
self.feedback_message = f"release_type: {self.package_meta.release_type.value}, homebrew_channel: {self.package_meta.homebrew_channel.value}"

Expand Down
17 changes: 17 additions & 0 deletions src/redis_release/bht/tree_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,6 +529,23 @@ def create_build_workflow_inputs(
release_meta,
log_prefix=log_prefix,
)
def create_publish_workflow_inputs(
self,
name: str,
workflow: Workflow,
package_meta: PackageMeta,
release_meta: ReleaseMeta,
log_prefix: str,
) -> Behaviour:

return HomewbrewWorkflowInputs(
name,
workflow,
cast(HomebrewMeta, package_meta),
release_meta,
log_prefix=log_prefix,
)



# Factory registry
Expand Down