Skip to content

[fix] Ensuring a clean environment is used when multiple tests share the same remote machines #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2021
Merged

[fix] Ensuring a clean environment is used when multiple tests share the same remote machines #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "redisbench-admin"
version = "0.4.5"
version = "0.4.6"
description = "Redis benchmark run helper. A wrapper around Redis and Redis Modules benchmark tools ( ftsb_redisearch, memtier_benchmark, redis-benchmark, aibench, etc... )."
authors = ["filipecosta90 <filipecosta.90@gmail.com>"]
readme = "README.md"
Expand Down
15 changes: 15 additions & 0 deletions redisbench_admin/run_remote/run_remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
get_run_full_filename,
get_overall_dashboard_keynames,
check_ec2_env,
execute_remote_commands,
)

from redisbench_admin.utils.utils import (
Expand Down Expand Up @@ -199,6 +200,19 @@ def run_remote_command_logic(args, project_name, project_version):
# after we've created the env, even on error we should always teardown
# in case of some unexpected error we fail the test
try:
# ensure /tmp folder is free of benchmark data from previous runs
remote_working_folder = "/tmp"
execute_remote_commands(
server_public_ip,
username,
private_key,
[
"rm -rf {}/*.log".format(remote_working_folder),
"rm -rf {}/*.rdb".format(remote_working_folder),
"rm -rf {}/*.out".format(remote_working_folder),
"rm -rf {}/*.data".format(remote_working_folder),
],
)
_, _, testcase_start_time_str = get_start_time_vars()
logname = "{}_{}.log".format(
test_name, testcase_start_time_str
Expand Down Expand Up @@ -287,6 +301,7 @@ def run_remote_command_logic(args, project_name, project_version):
result = wait_for_conn(
local_redis_conn, dataset_load_timeout_secs
)
logging.info("Starting dataset loading...")
dataset_load_end_time = datetime.datetime.now()
if result is True:
logging.info("Redis available")
Expand Down