refactor: Use delete_client instead of close

Author: KShivendu

engine/base_client/client.py

@@ -119,9 +119,9 @@ def run_experiment(
         print("Experiment stage: Done")
         print("Results saved to: ", RESULTS_DIR)
 
-    def close(self):
-        self.uploader.close()
-        self.configurator.close()
+    def delete_client(self):
+        self.uploader.delete_client()
+        self.configurator.delete_client()
 
         for s in self.searchers:
-            s.close()
+            s.delete_client()

engine/base_client/configure.py

@@ -24,5 +24,5 @@ def configure(self, dataset: Dataset) -> Optional[dict]:
     def execution_params(self, distance, vector_size) -> dict:
         return {}
 
-    def close(self):
+    def delete_client(self):
         pass

engine/base_client/search.py

@@ -98,7 +98,7 @@ def search_all(
 
         total_time = time.perf_counter() - start
 
-        self.__class__.close()
+        self.__class__.delete_client()
 
         return {
             "total_time": total_time,
@@ -121,5 +121,5 @@ def post_search(self):
         pass
 
     @classmethod
-    def close(cls):
+    def delete_client(cls):
         pass

engine/base_client/upload.py

@@ -70,7 +70,7 @@ def upload(
 
         print(f"Total import time: {total_time}")
 
-        self.close()
+        self.delete_client()
 
         return {
             "post_upload": post_upload_stats,
@@ -99,5 +99,5 @@ def upload_batch(
         raise NotImplementedError()
 
     @classmethod
-    def close(cls):
+    def delete_client(cls):
         pass

engine/clients/pgvector/configure.py

@@ -51,5 +51,5 @@ def recreate(self, dataset: Dataset, collection_params):
 
         self.conn.close()
 
-    def close(self):
+    def delete_client(self):
         self.conn.close()

engine/clients/pgvector/search.py

@@ -44,7 +44,7 @@ def search_one(cls, vector, meta_conditions, top) -> List[Tuple[int, float]]:
         return cls.cur.fetchall()
 
     @classmethod
-    def close(cls):
+    def delete_client(cls):
         if cls.cur:
             cls.cur.close()
             cls.conn.close()

engine/clients/pgvector/upload.py

@@ -32,7 +32,7 @@ def upload_batch(
                 copy.write_row((i, embedding))
 
     @classmethod
-    def close(cls):
+    def delete_client(cls):
         if cls.cur:
             cls.cur.close()
             cls.conn.close()

engine/clients/qdrant/upload.py

@@ -63,6 +63,6 @@ def wait_collection_green(cls):
         return total
 
     @classmethod
-    def close(cls):
+    def delete_client(cls):
         if cls.client is not None:
             del cls.client

run.py

@@ -53,7 +53,7 @@ def run(
                     client.run_experiment(
                         dataset, skip_upload, skip_search, skip_if_exists
                     )
-                client.close()
+                client.delete_client()
 
                 # If the timeout is reached, the server might be still in the
                 # middle of some background processing, like creating the index.