-
Notifications
You must be signed in to change notification settings - Fork 411
#RI-4265 - Enhance the window opening in Electron #2174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
egor-zalenski
merged 13 commits into
feature/RI-2850_Electron_improvements
from
build/feature/RI-4265_Enchance_opening_window_Electron
Jun 12, 2023
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4ff278f
#RI-4265 - Enchance opening window
egor-zalenski fa863d6
#RI-4265 - Enhance the window opening in Electron
egor-zalenski f9447d7
#RI-4265 - Enhance the window opening in Electron
egor-zalenski ce1619a
#RI-4265 - Enhance the window opening in Electron
egor-zalenski d03d882
#RI-4265 - Enhance the window opening in Electron
egor-zalenski 2cd4674
#RI-4265 - Enhance the window opening in Electron
egor-zalenski dd3082d
commit
egor-zalenski a40d623
Revert "#RI-4265 - Enchance opening window"
egor-zalenski 7081c30
#RI-4265 - rename envVars to ENV_VARS
egor-zalenski db8ec2f
#RI-4265 - Enchance opening window Electron
egor-zalenski db05227
#RI-4265 - Enchance opening window Electron
egor-zalenski 1d28493
#RI-4265 - Enchance opening window Electron
egor-zalenski bd76a67
#RI-4265 - Enchance opening window Electron
egor-zalenski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,7 @@ | ||
import webpack from 'webpack'; | ||
import { merge } from 'webpack-merge'; | ||
import { BundleAnalyzerPlugin } from 'webpack-bundle-analyzer'; | ||
import { toString } from 'lodash' | ||
import mainProdConfig from './webpack.config.main.prod.babel'; | ||
import mainProdConfig from './webpack.config.main.prod'; | ||
import DeleteSourceMaps from '../scripts/DeleteSourceMaps'; | ||
import { version } from '../redisinsight/package.json'; | ||
|
||
|
@@ -31,9 +30,6 @@ export default merge(mainProdConfig, { | |
APP_VERSION: version, | ||
AWS_BUCKET_NAME: 'AWS_BUCKET_NAME' in process.env ? process.env.AWS_BUCKET_NAME : '', | ||
SEGMENT_WRITE_KEY: 'SEGMENT_WRITE_KEY' in process.env ? process.env.SEGMENT_WRITE_KEY : 'SOURCE_WRITE_KEY', | ||
CONNECTIONS_TIMEOUT_DEFAULT: 'CONNECTIONS_TIMEOUT_DEFAULT' in process.env | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why did you remove this env? |
||
? process.env.CONNECTIONS_TIMEOUT_DEFAULT | ||
: toString(30 * 1000), // 30 sec | ||
}), | ||
], | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
import path from 'path'; | ||
egor-zalenski marked this conversation as resolved.
Show resolved
Hide resolved
|
||
import webpack from 'webpack'; | ||
import { merge } from 'webpack-merge'; | ||
import { BundleAnalyzerPlugin } from 'webpack-bundle-analyzer'; | ||
import baseConfig from './webpack.config.base'; | ||
import webpackPaths from './webpack.paths'; | ||
|
||
const configuration: webpack.Configuration = { | ||
devtool: 'inline-source-map', | ||
|
||
mode: 'development', | ||
|
||
target: 'electron-preload', | ||
|
||
entry: path.join(webpackPaths.electronPath, 'preload.ts'), | ||
|
||
output: { | ||
path: webpackPaths.dllPath, | ||
filename: 'preload.js', | ||
library: { | ||
type: 'umd', | ||
}, | ||
}, | ||
|
||
plugins: [ | ||
new BundleAnalyzerPlugin({ | ||
analyzerMode: process.env.ANALYZE === 'true' ? 'server' : 'disabled', | ||
}), | ||
|
||
/** | ||
* Create global constants which can be configured at compile time. | ||
* | ||
* Useful for allowing different behaviour between development builds and | ||
* release builds | ||
* | ||
* NODE_ENV should be production so that modules do not perform certain | ||
* development checks | ||
* | ||
* By default, use 'development' as NODE_ENV. This can be overriden with | ||
* 'staging', for example, by changing the ENV variables in the npm scripts | ||
*/ | ||
new webpack.EnvironmentPlugin({ | ||
NODE_ENV: 'development', | ||
}), | ||
|
||
new webpack.LoaderOptionsPlugin({ | ||
debug: true, | ||
}), | ||
], | ||
|
||
/** | ||
* Disables webpack processing of __dirname and __filename. | ||
* If you run the bundle in node.js it falls back to these values of node.js. | ||
* https://github.com/webpack/webpack/issues/2010 | ||
*/ | ||
node: { | ||
__dirname: false, | ||
__filename: false, | ||
}, | ||
|
||
watch: true, | ||
}; | ||
|
||
export default merge(baseConfig, configuration); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.